On Tue, 8 Aug 2023 23:43:00 GMT, Kimura Yukihiro wrote:
>> I would like to fix this issue
>> because the svc jtreg test does not pass on localized Windows platform.
>> Testing:
>> all serviceability area tests (jdk_svc group).
>>
>> Could anyone review the fix please?
>>
>> Thanks,
>> Kimura
> There is coding e.g. in
> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
> that deals with shared lib naming on different OS.
> This code should be simplified.
Matthias Baesken has updated the pull request incrementally with one additi
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
> Matthias
On Fri, 4 Aug 2023 09:59:41 GMT, Matthias Baesken wrote:
> There is coding e.g. in
> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
> that deals with shared lib naming on different OS.
> This code should be simplified.
This pull reques
On Thu, 10 Aug 2023 07:44:58 GMT, Matthias Baesken wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
> Matthias
> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
> tests, this patch tries to consolidate them into one method.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
fix TestHeapDumpForInvokDynamic
-
On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov wrote:
> The test uses this code to create a list of valid addresses for the localhost:
>
> String hostname = "localhost";
> List validAddresses = new LinkedList<>();
> validAddresses.add(hostname);
> Arrays.stream(
Hi, this patch fixes a VMReg encoding issue in `RISCV64Frame.java`. As the
VMReg has two slots in a 64-bit VM, the encoding of `fp` should be `8 << 1`
instead of `8`.
Testing:
- [x] tier1 with release build
- [ ] tier2 with release build
- [ ] tier3 with release build
-
Commit mess
On Tue, 8 Aug 2023 18:50:25 GMT, Leonid Mesnik wrote:
> Test might times out if it suspend thread before it starts breakpoint event
> handler.
> The fix is to replace sleep with better synchronization and suspend virtual
> thread only when it runs native code.
>
> Also, the completed monitor i
On Thu, 10 Aug 2023 09:41:29 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last rev
On Mon, 7 Aug 2023 20:17:21 GMT, Chris Plummer wrote:
> Make sure when walking the stack that the "sender" frame is not at a lower or
> the same address as the current frame, which can result in an infinite loop.
>
> Tested with tier1 and stress testing sun/tools/jhsdb and
> hotspot/jtreg/serv
On Mon, 7 Aug 2023 20:17:21 GMT, Chris Plummer wrote:
> Make sure when walking the stack that the "sender" frame is not at a lower or
> the same address as the current frame, which can result in an infinite loop.
>
> Tested with tier1 and stress testing sun/tools/jhsdb and
> hotspot/jtreg/serv
On Mon, 7 Aug 2023 20:17:21 GMT, Chris Plummer wrote:
> Make sure when walking the stack that the "sender" frame is not at a lower or
> the same address as the current frame, which can result in an infinite loop.
>
> Tested with tier1 and stress testing sun/tools/jhsdb and
> hotspot/jtreg/serv
On Thu, 10 Aug 2023 17:01:30 GMT, Kevin Walls wrote:
> Looks good to me, although do you think it could return null rather than
> throw a RuntimeException? Concerned we might not always want the Tool to fail
> and end there.
I chose throwing an exception, because this is what more commonly hap
On Thu, 10 Aug 2023 18:11:02 GMT, Andrew Haley wrote:
> I wonder what triggers this problem. Maybe there's an underlying bug, or
> maybe it's just to do with AArch64's weakly-consistent memory model.
Yes, you are correct, and I already filed
[JDK-8313800](https://bugs.openjdk.org/browse/JDK-83
On Thu, 10 Aug 2023 09:41:29 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last rev
On Thu, 10 Aug 2023 07:17:04 GMT, Kimura Yukihiro wrote:
> Can I type "integrate" or should I wait until some labels are added on JBS?
I added the `noreg-self` label, which means it is test bug, and assigned the CR
to you. You can integrate now.
-
PR Comment: https://git.openjdk.o
On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov wrote:
> The test uses this code to create a list of valid addresses for the localhost:
>
> String hostname = "localhost";
> List validAddresses = new LinkedList<>();
> validAddresses.add(hostname);
> Arrays.stream(
On Thu, 10 Aug 2023 09:41:29 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last rev
On OSX, don't require that sudo be used to launch SA tools if developer mode is
enabled. More details are in the CR.
Due to this change, the following tests are no longer being skipped if the host
has developer mode is enabled. They previously required running as root because
if sudo was used
On Thu, 10 Aug 2023 09:41:29 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last rev
> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
> tests, this patch tries to consolidate them into one method.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
review from Alex
-
Changes:
- al
On Thu, 10 Aug 2023 19:29:27 GMT, Alex Menkov wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix TestHeapDumpForInvokDynamic
>
> test/hotspot/jtreg/serviceability/sa/TestHeapDumpForInvokeDynamic.java line
> 40:
>
>>
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
24 matches
Mail list logo
