On Thu, 10 Aug 2023 09:41:29 GMT, Yi Yang <yy...@openjdk.org> wrote: >> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several >> tests, this patch tries to consolidate them into one method. > > Yi Yang has updated the pull request incrementally with one additional commit > since the last revision: > > fix TestHeapDumpForInvokDynamic
Can you clarify what testing you did? I don't see BasicJMapTest.java being run as part of GHA. I also don't see com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java being run, which is impacted by your changes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15202#issuecomment-1673756439
