On Mon, 7 Aug 2023 20:17:21 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

> Make sure when walking the stack that the "sender" frame is not at a lower or 
> the same address as the current frame, which can result in an infinite loop.
> 
> Tested with tier1 and stress testing sun/tools/jhsdb and 
> hotspot/jtreg/serviceability/sa tests.

Looks good to me, although do you think it could return null rather than throw 
a RuntimeException?  Concerned we might not always want the Tool to fail and 
end there.

-------------

Marked as reviewed by kevinw (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15183#pullrequestreview-1572355329

Reply via email to