On Wed, 2 Aug 2023 18:02:22 GMT, Chris Plummer wrote:
> so I'm still wondering how this use of SATestUtils.createProcessBuilder()
> got in this new test in the first place
I simply grep existing tests and found this snippet to create java process.
There is no special intention, it is an obvio
On Wed, 2 Aug 2023 06:59:00 GMT, Yi Yang wrote:
>> I see now that this is a new test, and not an SA test, so probably should
>> never have been using SATestUtils in the first place (I'm curious as to how
>> that ended up happening). You should also remove the import of SATestUtils.
>
>> Before
On Tue, 1 Aug 2023 17:48:30 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/serviceability/HeapDump/IntegrityHeapDumpTest.java line
>> 84:
>>
>>> 82: .addToolArg(heapDumpFile.getAbsolutePath());
>>> 83:
>>> 84: ProcessBuilder processBuilder = new
>>> ProcessBuilder(lau
On Tue, 1 Aug 2023 14:41:53 GMT, Kevin Walls wrote:
> I just saw a run with no -parallel option which got num_active_workers = 2,
> so it did a parallel dump, so the default is being set as intended, but the
> availability of worker threads is not always predictable!
Yes, now I've added new lo
On Tue, 1 Aug 2023 17:32:55 GMT, Chris Plummer wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test failure on mac
>
> test/hotspot/jtreg/serviceability/HeapDump/IntegrityHeapDumpTest.java line 84:
>
>> 82:
On Tue, 1 Aug 2023 05:50:42 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
On Tue, 1 Aug 2023 05:50:42 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
> ### Motivation and proposal
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent threads
> competitively write heap data to the sam
