On Wed, 2 Jul 2025 19:02:30 GMT, Coleen Phillimore wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @coleenp comments
>
> Marked as reviewed by coleenp (Reviewer).
Thanks @coleenp @calvinccheung @sspitsyn for the review
On Wed, 2 Jul 2025 18:14:57 GMT, Ioi Lam wrote:
>> A module has both a Java and a C++ representation
>>
>> - C++: `ModuleEntry`
>> - Java: `java.lang.Module`
>>
>> In C++, we have the following two methods
>>
>> - `ModuleEntry* InstanceKlass::module()`
>> - `oop ModuleEntry::module()`
>>
>> T
On Wed, 2 Jul 2025 21:25:04 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @coleenp comments
>
> src/hotspot/share/classfile/moduleEntry.cpp line 52:
>
>> 50: ModuleEntry* ModuleEntryTable::_javabas
On Wed, 2 Jul 2025 18:14:57 GMT, Ioi Lam wrote:
>> A module has both a Java and a C++ representation
>>
>> - C++: `ModuleEntry`
>> - Java: `java.lang.Module`
>>
>> In C++, we have the following two methods
>>
>> - `ModuleEntry* InstanceKlass::module()`
>> - `oop ModuleEntry::module()`
>>
>> T
On Wed, 2 Jul 2025 18:14:57 GMT, Ioi Lam wrote:
>> A module has both a Java and a C++ representation
>>
>> - C++: `ModuleEntry`
>> - Java: `java.lang.Module`
>>
>> In C++, we have the following two methods
>>
>> - `ModuleEntry* InstanceKlass::module()`
>> - `oop ModuleEntry::module()`
>>
>> T
> A module has both a Java and a C++ representation
>
> - C++: `ModuleEntry`
> - Java: `java.lang.Module`
>
> In C++, we have the following two methods
>
> - `ModuleEntry* InstanceKlass::module()`
> - `oop ModuleEntry::module()`
>
> This can lead to confusing code like this:
>
>
> InstanceKla
On Wed, 2 Jul 2025 17:50:52 GMT, Coleen Phillimore wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @coleenp comments
>
> src/hotspot/share/runtime/reflection.cpp line 582:
>
>> 580: } else {
>> 581: oop m
On Wed, 2 Jul 2025 17:33:40 GMT, Ioi Lam wrote:
> A module has both a Java and a C++ representation
>
> - C++: `ModuleEntry`
> - Java: `java.lang.Module`
>
> In C++, we have the following two methods
>
> - `ModuleEntry* InstanceKlass::module()`
> - `oop ModuleEntry::module()`
>
> This can lea
