Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-25 Thread Martin Doerr
On Thu, 19 Dec 2024 20:27:28 GMT, Coleen Phillimore wrote: >> src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp line 691: >> >>> 689: >>> 690: // Skip if we don't have to unlock. (???is this right???) >>> 691: rldicl_(R0, Raccess_flags, 64-JVM_ACC_SYNCHRONIZED_BIT, 63); // >>> Extract bit and

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Coleen Phillimore
On Thu, 19 Dec 2024 19:08:06 GMT, Dean Long wrote: >> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp >> >>Co-authored-by: David Holmes >> <6209

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Coleen Phillimore
On Thu, 19 Dec 2024 13:48:16 GMT, Andrew Haley wrote: >> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp >> >>Co-authored-by: David Holmes >> <6

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Dean Long
On Thu, 19 Dec 2024 12:52:34 GMT, Coleen Phillimore wrote: >> Please review this change that makes AccessFlags and modifier_flags u2 types >> and removes the last remnants of Hotspot adding internal access flags. This >> change moves AccessFlags and modifier_flags in Klass to alignment gaps >

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Andrew Haley
On Thu, 19 Dec 2024 12:52:34 GMT, Coleen Phillimore wrote: >> Please review this change that makes AccessFlags and modifier_flags u2 types >> and removes the last remnants of Hotspot adding internal access flags. This >> change moves AccessFlags and modifier_flags in Klass to alignment gaps >

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Coleen Phillimore
On Thu, 19 Dec 2024 01:33:57 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp >> >>Co-authored-by: David Holmes >> <6

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Coleen Phillimore
On Thu, 19 Dec 2024 01:48:49 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp >> >>Co-authored-by: David Holmes >> <6

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v2]

2024-12-19 Thread Coleen Phillimore
> Please review this change that makes AccessFlags and modifier_flags u2 types > and removes the last remnants of Hotspot adding internal access flags. This > change moves AccessFlags and modifier_flags in Klass to alignment gaps saving > 16 bytes. From pahole: so it's a bit better. > > befor