On Tue, 7 Jan 2025 20:59:18 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make more AccessFlags fetches more specific and remove an assert and
>> remove this->s.
>
> src/hotspot/share/classfi
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Mon, 6 Jan 2025 13:47:35 GMT, Coleen Phillimore wrote:
>> Yes, we are.
>
> I had a little experiment.
>
> extern "C" int printf(const char *,...);
> int main() {
> unsigned short ss = 0x8000;
> printf("does unsigned sign extend to int? %d\n", int(ss));
> }
IMO you could just call `as_int
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Mon, 6 Jan 2025 16:46:25 GMT, Serguei Spitsyn wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused SA function.
>
> src/hotspot/share/interpreter/linkResolver.cpp line 586:
>
>> 584: // We nee
On Mon, 6 Jan 2025 14:12:56 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Mon, 6 Jan 2025 14:12:56 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Mon, 6 Jan 2025 13:44:27 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/ci/ciFlags.cpp line 95:
>>
>>> 93: // ciFlags::print
>>> 94: void ciFlags::print(outputStream* st) {
>>> 95: st->print(" flags=%x", _flags.as_unsigned_short());
>>
>> Here, and elsewhere, are we relying on an impli
On Mon, 6 Jan 2025 03:47:05 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix more copyrights.
>
> src/hotspot/share/ci/ciFlags.hpp line 71:
>
>> 69:
>> 70: // Conversion
>> 71: jint
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Mon, 6 Jan 2025 03:44:09 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix more copyrights.
>
> src/hotspot/share/ci/ciFlags.cpp line 95:
>
>> 93: // ciFlags::print
>> 94: void ciFlags:
On Fri, 3 Jan 2025 22:00:34 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Thu, 2 Jan 2025 23:33:31 GMT, Serguei Spitsyn wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Happy New Year
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1151:
>
>> 1149: // methods matc
On Thu, 2 Jan 2025 13:20:20 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Thu, 2 Jan 2025 13:20:20 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Thu, 2 Jan 2025 13:05:10 GMT, Coleen Phillimore wrote:
>> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 149:
>>
>>> 147: // _access_flags must be a 16 bit value.
>>> 148: assert(sizeof(AccessFlags) == 2, "wrong size");
>>> 149: __ lha(R11_scratch1/*access_flags*/,
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Thu, 2 Jan 2025 13:08:12 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Wed, 25 Dec 2024 16:40:19 GMT, Martin Doerr wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore ACC in comment.
>
> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 149:
>
>> 147: // _
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Fri, 20 Dec 2024 21:34:58 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore ACC in comment.
>
> src/hotspot/share/oops/method.cpp line 1655:
>
>> 1653: return;
>> 1654: }
>> 1655
On Thu, 2 Jan 2025 12:34:59 GMT, Coleen Phillimore wrote:
>> The instruction looks still correct. We are checking the same bit of the 64
>> bit register as before. (Using `testbitdi` would also work.)
>
> I changed this to testbitdi.
Ok.
-
PR Review Comment: https://git.openjdk.or
On Wed, 25 Dec 2024 16:34:27 GMT, Martin Doerr wrote:
>> It wasn't the logic. When I went through I didn't know if this instruction
>> needed fixing because we loaded an unsigned short instead of an int. So I
>> left myself a note to look at it again that you noticed and I didn't in my
>> fi
On Wed, 25 Dec 2024 22:35:02 GMT, Andrew Haley wrote:
> > This is breaking s390x build. Would you please added below patch :)
>
> Maybe `testbit_16` isn't the rbest name. Perhaps `testbit_ushort` is better?
Sure, updated patch:
[s390_port_updated.patch](https://github.com/user-attachments/file
On Wed, 25 Dec 2024 07:46:00 GMT, Amit Kumar wrote:
> This is breaking s390x build. Would you please added below patch :)
Maybe `testbit_16` isn't the rbest name. Perhaps `testbit_ushort` is better?
-
PR Comment: https://git.openjdk.org/jdk/pull/22246#issuecomment-2562014053
On Fri, 20 Dec 2024 13:17:17 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Thu, 19 Dec 2024 12:54:20 GMT, Coleen Phillimore wrote:
>> src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp line 690:
>>
>>> 688: push(state);
>>> 689:
>>> 690: // Skip if we don't have to unlock. (???is this right???)
>>
>> The logic seems consistent with other platforms. Not sure what y
On Thu, 19 Dec 2024 20:27:28 GMT, Coleen Phillimore wrote:
>> src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp line 691:
>>
>>> 689:
>>> 690: // Skip if we don't have to unlock. (???is this right???)
>>> 691: rldicl_(R0, Raccess_flags, 64-JVM_ACC_SYNCHRONIZED_BIT, 63); //
>>> Extract bit and
On Fri, 20 Dec 2024 13:17:17 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Fri, 20 Dec 2024 13:17:17 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Thu, 19 Dec 2024 01:40:41 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore ACC in comment.
>
> src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp line 75:
>
>> 73: while (
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Thu, 19 Dec 2024 22:22:13 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Thu, 19 Dec 2024 20:15:14 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Thu, 19 Dec 2024 12:47:19 GMT, Coleen Phillimore wrote:
> I could change the name to as_unsigned_short(). Would that be less confusing?
How about `as_u2()` as that is what it is? (less typing :) ).
-
PR Comment: https://git.openjdk.org/jdk/pull/22246#issuecomment-2555777513
On Thu, 19 Dec 2024 19:08:06 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>>
>>Co-authored-by: David Holmes
>> <6209
On Thu, 19 Dec 2024 13:48:16 GMT, Andrew Haley wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>>
>>Co-authored-by: David Holmes
>> <6
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Thu, 19 Dec 2024 12:52:34 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Thu, 19 Dec 2024 12:52:34 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>
On Thu, 19 Dec 2024 01:33:57 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>>
>>Co-authored-by: David Holmes
>> <6
On Thu, 19 Dec 2024 01:48:49 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>>
>>Co-authored-by: David Holmes
>> <6
On Tue, 19 Nov 2024 16:18:48 GMT, Coleen Phillimore wrote:
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps savin
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps saving
> 16 bytes. From pahole: so it's a bit better.
>
> befor
On Tue, 19 Nov 2024 16:18:48 GMT, Coleen Phillimore wrote:
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps savin
57 matches
Mail list logo
