Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v6]

2024-08-14 Thread Chris Plummer
On Tue, 13 Aug 2024 22:28:10 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback.

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v6]

2024-08-14 Thread Serguei Spitsyn
On Tue, 13 Aug 2024 22:28:10 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback.

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v5]

2024-08-14 Thread Chris Plummer
On Tue, 13 Aug 2024 21:18:04 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> git rid of unnecessary @build > > Looks good. @sspitsyn or @lmesnik I need a final review since I made a minor cod

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v6]

2024-08-14 Thread Leonid Mesnik
On Tue, 13 Aug 2024 22:28:10 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback.

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v6]

2024-08-13 Thread Chris Plummer
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The agent is free to do pretty much what it wants during the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v5]

2024-08-13 Thread Leonid Mesnik
On Mon, 12 Aug 2024 21:35:49 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback.

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v5]

2024-08-13 Thread Serguei Spitsyn
On Mon, 12 Aug 2024 21:35:49 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback.

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v2]

2024-08-12 Thread Chris Plummer
On Mon, 12 Aug 2024 19:22:13 GMT, Leonid Mesnik wrote: >> It's not needed because it is in the same file. I'm not even sure it would >> work. > > ough, I mean 'is @build DataDumpTest' needed to build DataDumpTestTarg? The > DataDumpTest should be built without explicit @build command. Ok. I re

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v5]

2024-08-12 Thread Chris Plummer
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The agent is free to do pretty much what it wants during the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v2]

2024-08-12 Thread Leonid Mesnik
On Thu, 8 Aug 2024 20:56:16 GMT, Chris Plummer wrote: >> test/jdk/com/sun/jdi/DataDumpTest.java line 51: >> >>> 49: * @library /test/lib >>> 50: * @modules jdk.jdi >>> 51: * @build DataDumpTest >> >> Is the build needed to build 'DataDumpTestTarg' because it is not explicitly >> used by the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent [v4]

2024-08-12 Thread Chris Plummer
On Wed, 31 Jul 2024 10:12:16 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Get rid of timeout. Use driver instead of othervm > > First, it is a good idea to implement/enable this. > It looks

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v4]

2024-08-08 Thread Chris Plummer
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The agent is free to do pretty much what it wants during the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v2]

2024-08-08 Thread Chris Plummer
On Thu, 8 Aug 2024 19:59:04 GMT, Leonid Mesnik wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Minor improvment to datadump output >> - Add test cast for new debug agent datadump support > > test/jdk/com/sun/jd

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v3]

2024-08-08 Thread Chris Plummer
On Thu, 8 Aug 2024 21:05:00 GMT, Leonid Mesnik wrote: > > FYI, this is what the (entire) debuggee output looks like for this test: > > ``` > > Deuggee output: > > ``` > > Should we see the same report for CTRL+\ or after sending SIGQUIT signal? I > see it should cause this request. Yes, I beli

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v3]

2024-08-08 Thread Leonid Mesnik
On Thu, 8 Aug 2024 20:59:24 GMT, Chris Plummer wrote: > FYI, this is what the (entire) debuggee output looks like for this test: > > ``` > Deuggee output: > Should we see the same report for CTRL+\ or after sending SIGQUIT signal? I see it should cause this request. - PR Comment:

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v3]

2024-08-08 Thread Chris Plummer
On Thu, 8 Aug 2024 20:06:08 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback. T

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v2]

2024-08-08 Thread Leonid Mesnik
On Thu, 8 Aug 2024 19:28:09 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback. T

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v3]

2024-08-08 Thread Leonid Mesnik
On Thu, 8 Aug 2024 20:06:08 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback. T

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v3]

2024-08-08 Thread Chris Plummer
On Thu, 8 Aug 2024 20:06:08 GMT, Chris Plummer wrote: >> JVMTI has a somewhat unique event called DataDumpRequest. One way it is >> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the >> DataDumpRequest event to all agents that have registered for the event >> callback. T

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v3]

2024-08-08 Thread Chris Plummer
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The agent is free to do pretty much what it wants during the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent. [v2]

2024-08-08 Thread Chris Plummer
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The agent is free to do pretty much what it wants during the

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent.

2024-07-31 Thread Chris Plummer
On Wed, 31 Jul 2024 10:12:16 GMT, Serguei Spitsyn wrote: > Did you consider to add a test for this? Good idea. I'll add one. - PR Comment: https://git.openjdk.org/jdk/pull/20367#issuecomment-2260951141

Re: RFR: 8332488: Add JVMTI DataDumpRequest to the debug agent.

2024-07-31 Thread Serguei Spitsyn
On Sat, 27 Jul 2024 02:12:33 GMT, Chris Plummer wrote: > JVMTI has a somewhat unique event called DataDumpRequest. One way it is > triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the > DataDumpRequest event to all agents that have registered for the event > callback. The