On Thu, 22 Jun 2023 13:44:53 GMT, Daniel D. Daugherty
wrote:
>> Daohan Qu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a simple check
>
> Folks the GHA for this PR reported a failure in
> serviceability/sa/ClhsdbDumpclass
> on w
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 08:59:42 GMT, Kevin Walls wrote:
> I see the failure too. javap needs "-v" to show the StackMap info, I see that
> on linux release and debug builds.
Exactly! @kevinjwalls. And a situation similar to [this
one](https://github.com/openjdk/jdk/pull/3004#issuecomment-800679752
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 07:38:21 GMT, David Holmes wrote:
> What output is the test looking for i.e why is supposed to be writing it? If
> it is the if (DEBUG) debugMessage(...) calls they are not enabled.
It is looking for `StackMapTable` info in the javap output.
> I've filed https://bugs.openjd
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 04:00:14 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 02:37:08 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
> `buildreplayjars` command. This bug manifests itself during my diagnosing
> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
> fixed first.
>
> I have run jtreg test `tier1-3` of release bu
On Thu, 22 Jun 2023 02:55:47 GMT, Daohan Qu wrote:
> Maybe we could add a validation in `ClhsdbDumpclass.java` to ensure that the
> generated class file contains some `StackMapTable`s? (As the class under
> validation `LingeredApp` should has `StackMapTable`s for some methods.)
It'd be nice to
On Thu, 22 Jun 2023 02:37:08 GMT, Daohan Qu wrote:
>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
>> `buildreplayjars` command. This bug manifests itself during my diagnosing
>> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
>> fixed
On Thu, 22 Jun 2023 02:55:47 GMT, Daohan Qu wrote:
> Maybe we could add a validation in `ClhsdbDumpclass.java` to ensure that the
> generated class file contains some `StackMapTable`s? (As the class under
> validation `LingeredApp` should has `StackMapTable`s for some methods.)
It would be nic
On Wed, 21 Jun 2023 20:26:20 GMT, Chris Plummer wrote:
>> Daohan Qu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix some code format issues
>
> I made a couple of minor suggestions. Otherwise it looks good.
Thank @plummercj and @ssp
On Wed, 21 Jun 2023 20:42:04 GMT, Serguei Spitsyn wrote:
>> Daohan Qu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix some code format issues
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java
> lin
On Wed, 21 Jun 2023 20:19:59 GMT, Chris Plummer wrote:
>> Daohan Qu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix some code format issues
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstMethod.java
> line 113:
>
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
> `buildreplayjars` command. This bug manifests itself during my diagnosing
> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
> fixed first.
>
> I have run jtreg test `tier1-3` of release bu
On Tue, 20 Jun 2023 11:31:40 GMT, Daohan Qu wrote:
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
> `buildreplayjars` command. This bug manifests itself during my diagnosing
> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
> fixed firs
On Tue, 20 Jun 2023 11:31:40 GMT, Daohan Qu wrote:
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
> `buildreplayjars` command. This bug manifests itself during my diagnosing
> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
> fixed firs
On Tue, 20 Jun 2023 14:02:35 GMT, Ashutosh Mehra wrote:
> On another note since you mentioned
> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) I should let you
> know I have a fix for it and am planning to open a PR soon.
Good news! Never mind and thanks for your notice 😄.
---
On Tue, 20 Jun 2023 11:31:40 GMT, Daohan Qu wrote:
> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s
> `buildreplayjars` command. This bug manifests itself during my diagnosing
> [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be
> fixed firs
23 matches
Mail list logo
