On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote:
>>> > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
>>>
>>> * CSR: not sure; there are precedences for going with CSR and without
>>> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR
>>> n
On Fri, 10 Nov 2023 07:38:24 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Fri, 10 Nov 2023 09:45:11 GMT, Johan Sjölen wrote:
> Hi Thomas,
>
> Thanks for your hard work on this! LGTM.
Thank you for your Review, Johan!
-
PR Comment: https://git.openjdk.org/jdk/pull/16301#issuecomment-1805489022
On Fri, 10 Nov 2023 07:38:24 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote:
>>> > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
>>>
>>> * CSR: not sure; there are precedences for going with CSR and without
>>> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR
>>> n
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Thu, 9 Nov 2023 07:27:37 GMT, David Holmes wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix another windows error
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1193:
>
>> 1191: output()->pri
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Thu, 9 Nov 2023 07:26:46 GMT, David Holmes wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix another windows error
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1159:
>
>> 1157: }
>> 1158:
>> 11
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools ou
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote:
> > > > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
> > >
> > >
> > > ```
> > > * CSR: not sure; there are precedences for going with CSR and without
> > > CSR. Since we get awfully close to JDK22 freeze, I would pr
On Wed, 8 Nov 2023 11:40:35 GMT, Johan Sjölen wrote:
> > > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
> >
> >
> > ```
> > * CSR: not sure; there are precedences for going with CSR and without CSR.
> > Since we get awfully close to JDK22 freeze, I would prefer for a C
On Wed, 8 Nov 2023 11:24:43 GMT, Thomas Stuefe wrote:
> > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
>
> * CSR: not sure; there are precedences for going with CSR and without
> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR not
> to be
On Wed, 8 Nov 2023 09:51:12 GMT, Johan Sjölen wrote:
> As this adds a JCmd, doesn't this need both a CSR and a manual entry?
- CSR: not sure; there are precedences for going with CSR and without CSR.
Since we get awfully close to JDK22 freeze, I would prefer for a CSR not to be
needed. Also wo
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools ou
On Wed, 1 Nov 2023 10:04:30 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> OK, went through the cache. Will continue later.
> @jdksjolen anything more needed from my side
On Wed, 1 Nov 2023 10:04:30 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> OK, went through the cache. Will continue later.
@jdksjolen anything more needed from my side?
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools ou
On Thu, 2 Nov 2023 15:25:14 GMT, Brice Dutheil wrote:
>> This prints protection and offset. The former is interesting for obvious
>> reasons (e.g. lets you tell apart stack guard regions from stack, or
>> uncommitted from committed regions) and the latter interesting for some
>> corner cases (
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Wed, 1 Nov 2023 06:26:57 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/linux/memMapPrinter_linux.cpp line 59:
>>
>>> 57: void print_OS_specific_details(outputStream* st) const override {
>>> 58: st->print("%s %s ", _info.prot, _info.offset);
>>> 59: }
>>
>> If that's all this is doing,
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Wed, 1 Nov 2023 15:38:46 GMT, Gerard Ziemski wrote:
> LGTM
>
> Thank you for doing this!
Thank you for reviewing, @gerard-ziemski !
-
PR Comment: https://git.openjdk.org/jdk/pull/16301#issuecomment-1790665200
On Wed, 1 Nov 2023 10:04:04 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 119:
>
>> 117: assert(_capacity > _count, "San
On Wed, 1 Nov 2023 10:46:21 GMT, Johan Sjölen wrote:
>> Yes, it resulted in a significant performance gain for a test run where I
>> interleaved non-committed and committed memory of the same tag. I may have
>> been mistaken, of course.
>
> It being committed or reserved shouldn't matter (I ass
On Wed, 1 Nov 2023 10:09:40 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools ou
On Wed, 1 Nov 2023 10:13:03 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/nmt/memMapPrinter.cpp line 105:
>>
>>> 103: _ranges[_count - 1].to = to;
>>> 104: return true;
>>> 105: }
>>
>> I'm pretty sure that the virtual memory tracker already gives you the
>> minimal set of reg
On Wed, 1 Nov 2023 10:01:43 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 105:
>
>> 103: _ranges[_count - 1].to = to;
On Wed, 1 Nov 2023 09:52:24 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/nmt/memMapPrinter.cpp line 99:
>>
>>> 97: }
>>> 98:
>>> 99: bool add(const void* from, const void* to, MEMFLAGS f) {
>>
>> Please mention that we're `add`ing in sorted order, that is that `forall R
>> \in _ranges:
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Wed, 1 Nov 2023 09:48:39 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 99:
>
>> 97: }
>> 98:
>> 99: bool add(const v
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Wed, 1 Nov 2023 07:32:23 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/nmt/memMapPrinter.cpp line 79:
>>
>>> 77: const void* const min = MAX2(from1, from2);
>>> 78: const void* const max = MIN2(to1, to2);
>>> 79: return min < max;
>>
>> I had to rewrite it as:
>>
>> `return MAX2(from
On Wed, 1 Nov 2023 09:37:22 GMT, Johan Sjölen wrote:
>> I'll do the former, that is clearer I agree, but leave the latter out (I
>> assume with the macro you mean add it to globalDefenitions.hpp).
>>
>> I fear that a lot of bikeshedding and general discussions would start, and
>> to do it prop
On Tue, 31 Oct 2023 17:08:15 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 79:
>
>> 77: const void* const min = MAX2(fro
On Tue, 31 Oct 2023 16:58:19 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 59:
>
>> 57: void print_OS_specific_deta
On Mon, 30 Oct 2023 17:31:30 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 83:
>
>> 81: char line[linesize];
>> 8
On Mon, 30 Oct 2023 10:29:56 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 80:
>
>> 78: FILE* f = os::fopen("/proc/se
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Fri, 27 Oct 2023 09:42:19 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master and solve merge conflicts
>> - small fixes
>> - start from VM op; show mo
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Fri, 27 Oct 2023 20:20:49 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix spelling
>> - timeout fuse
>> - Feedback Johan
>
> src/hotspot/share/services/memMapPrinter.cpp line 95:
>
On Fri, 27 Oct 2023 15:42:06 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix spelling
>> - timeout fuse
>> - Feedback Johan
>
> Taking a look...
@gerard-ziemski @jdksjolen I take thi
On Fri, 27 Oct 2023 22:01:07 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix spelling
>> - timeout fuse
>> - Feedback Johan
>
> src/hotspot/share/services/memMapPrinter.cpp line 294:
On Fri, 27 Oct 2023 17:29:23 GMT, Gerard Ziemski wrote:
> I really like this feature, hope the other platforms can be done as well. (I
> am also really looking forward to seeing how you did the "malloc" version)
>
> I think we should set the user expectations correctly and say somewhere that
>
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Fri, 27 Oct 2023 12:28:51 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Fri, 27 Oct 2023 09:42:19 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master and solve merge conflicts
>> - small fixes
>> - start from VM op; show mo
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Fri, 27 Oct 2023 09:41:28 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master and solve merge conflicts
>> - small fixes
>> - start from VM op; show mo
On Fri, 27 Oct 2023 09:37:19 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master and solve merge conflicts
>> - small fixes
>> - start from VM op; show mo
On Fri, 27 Oct 2023 09:32:35 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master and solve merge conflicts
>> - small fixes
>> - start from VM op; show mo
On Fri, 27 Oct 2023 08:38:02 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master and solve merge conflicts
>> - small fixes
>> - start from VM op; show mo
On Thu, 26 Oct 2023 15:02:53 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Mon, 23 Oct 2023 05:25:50 GMT, Thomas Stuefe wrote:
> > The hs_err file includes a dump of the maps file. It seems these
> > annotations would be useful there also.
>
> I thought about this too. The problem is the printing may take long since it
> is O^2 (iterate through VMAs, for each one
On Mon, 23 Oct 2023 01:39:16 GMT, Chris Plummer wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Mon, 23 Oct 2023 01:39:16 GMT, Chris Plummer wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools o
On Mon, 23 Oct 2023 01:39:16 GMT, Chris Plummer wrote:
> The hs_err file includes a dump of the maps file. It seems these annotations
> would be useful there also.
I thought about this too. The problem is the printing may take long since it is
O^2 (iterate through VMAs, for each one iterate NM
On Sun, 22 Oct 2023 10:08:49 GMT, Thomas Stuefe wrote:
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out th
Analysts and supporters often use /proc/xx/maps to make sense of the memory
footprint of a process.
Interpreting the memory map correctly can help when used as a complement to
other tools (e.g. NMT). There even exist tools out there that attempt to
annotate the process memory map with JVM infor
67 matches
Mail list logo
