On Thu, 9 Nov 2023 07:27:37 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix another windows error
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1193:
>
>> 1191: output()->print_cr("Memory map dumped to \"%s\".", name);
>> 1192: } else {
>> 1193: output()->print_cr("Failed to open \"%s\" for writing.", name);
>
> Don't you want to report errno here?
I'm always leery about relying on errno from wrapper functions or objects like
this, unless they have an explicit channel to report the relevant errno. I
looked at fileStream, I guess its okay here. Okay, I'll add it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1389011079
