On Wed, 1 Nov 2023 10:01:43 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix various builds > > src/hotspot/share/nmt/memMapPrinter.cpp line 105: > >> 103: _ranges[_count - 1].to = to; >> 104: return true; >> 105: } > > I'm pretty sure that the virtual memory tracker already gives you the minimal > set of regions, have you observed this branch being taken? Yes, it resulted in a significant performance gain for a test run where I interleaved non-committed and committed memory of the same tag. I may have been mistaken, of course. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1378613209