Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v4]

2024-09-18 Thread Kevin Walls
On Wed, 18 Sep 2024 11:35:32 GMT, Erik Gahlin wrote: > Looks good. Have you run the jfr tests in test/jdk/jdk/jfr Thanks Leonid and Erik for reviewing. Yes, all tests are passing. - PR Comment: https://git.openjdk.org/jdk/pull/21021#issuecomment-2358234791

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v4]

2024-09-18 Thread Erik Gahlin
On Tue, 17 Sep 2024 14:32:22 GMT, Kevin Walls wrote: >> The few uses of the operation parameter type "JULONG" in Diagnostic Commands >> should be changed to INT. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > No comma in:

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v4]

2024-09-17 Thread Leonid Mesnik
On Tue, 17 Sep 2024 14:32:22 GMT, Kevin Walls wrote: >> The few uses of the operation parameter type "JULONG" in Diagnostic Commands >> should be changed to INT. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > No comma in:

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v4]

2024-09-17 Thread Kevin Walls
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands > should be changed to INT. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: No comma in: INT followed by... - Changes: - all: https://git.o

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v2]

2024-09-17 Thread Kevin Walls
On Tue, 17 Sep 2024 08:44:41 GMT, Kevin Walls wrote: >> The few uses of the operation parameter type "JULONG" in Diagnostic Commands >> should be changed to INT. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Additional ty

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v3]

2024-09-17 Thread Kevin Walls
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands > should be changed to INT. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Addition INTEGER to standard INT - Changes: - all: https://git.

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) [v2]

2024-09-17 Thread Kevin Walls
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands > should be changed to INT. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Additional typos/default values - Changes: - all: https://git.o

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view)

2024-09-16 Thread Sonia Zaldana Calles
On Mon, 16 Sep 2024 15:39:58 GMT, Kevin Walls wrote: > The few uses of the operation parameter type "JULONG" in Diagnostic Commands > should be changed to INT. Hi Kevin, I had some questions about this change. Regarding the `INTEGER` -> `INT` change, I was wondering if the plan was to also

Re: RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view)

2024-09-16 Thread Kevin Walls
On Mon, 16 Sep 2024 15:39:58 GMT, Kevin Walls wrote: > The few uses of the operation parameter type "JULONG" in Diagnostic Commands > should be changed to INT. Use of the operation parameter type description "JULONG" in Diagnostic Commands should be changed to INT. DiagnosticCommandMBean prov

RFR: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view)

2024-09-16 Thread Kevin Walls
The few uses of the operation parameter type "JULONG" in Diagnostic Commands should be changed to INT. - Commit messages: - Merge remote-tracking branch 'upstream/master' into 8340113_JULONG - 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view) Changes: ht