Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v14]

2024-11-18 Thread Magnus Ihse Bursie
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v14]

2024-11-15 Thread Ioi Lam
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v14]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v14]

2024-11-15 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v13]

2024-11-15 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v12]

2024-11-14 Thread John R Rose
On Fri, 15 Nov 2024 05:48:27 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v12]

2024-11-14 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v11]

2024-11-13 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v10]

2024-11-08 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v9]

2024-11-07 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-07 Thread Coleen Phillimore
On Thu, 7 Nov 2024 13:16:19 GMT, Coleen Phillimore wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @DanHeidinga comment -- exit VM when runtimeSetup() fails > > src/hotspot/share/cds/aotConstantPoolResolver.cpp line 2:

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-07 Thread Coleen Phillimore
On Mon, 4 Nov 2024 23:57:48 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https:

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-05 Thread Ioi Lam
On Wed, 6 Nov 2024 04:52:56 GMT, David Holmes wrote: > > I've been using AOT in class names and aot in function/variable names. I > > think that's consistent with HotSpot convention. > > As an acronym I think AOT in capitals should be preferred even in > function/variable names. I searched fo

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-05 Thread David Holmes
On Tue, 5 Nov 2024 01:10:37 GMT, Ioi Lam wrote: > I've been using AOT in class names and aot in function/variable names. I > think that's consistent with HotSpot convention. As an acronym I think AOT in capitals should be preferred even in function/variable names. > In logging, I've been usi

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-04 Thread Ioi Lam
On Tue, 5 Nov 2024 00:20:56 GMT, Vladimir Ivanov wrote: > Looks good. > > Stylistic comment: while browsing the code a mix of "AOT" & "aot" caught my > eye. I find the former spelling more descriptive. Any particular reason to > use "aot" unless all lowercase spelling is preferred in some part

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-04 Thread Vladimir Ivanov
On Mon, 4 Nov 2024 23:57:48 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https:

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-11-04 Thread Ioi Lam
On Mon, 4 Nov 2024 14:21:09 GMT, Dan Heidinga wrote: >> I think this is already done: >> >> `runtimeSetup()` is called inside `InstanceKlass::call_class_initializer()`. >> When that returns, we will proceed to >> `InstanceKlass::set_initialization_state_and_notify()` which will perform >> the

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v8]

2024-11-04 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v7]

2024-11-04 Thread Ashutosh Mehra
On Mon, 4 Nov 2024 03:15:25 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https:

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-11-04 Thread Dan Heidinga
On Mon, 4 Nov 2024 03:08:02 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotClassInitializer.cpp line 348: >> >>> 346: } >>> 347: JavaValue result(T_VOID); >>> 348: JavaCalls::call_static(&result, ik, >> >> Based on the discussions in JDK-8342283, do we need a memory fence after the

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v7]

2024-11-03 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-11-03 Thread Ioi Lam
On Fri, 1 Nov 2024 03:54:24 GMT, Dan Heidinga wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed whitespace; fixed minimal build > > src/hotspot/share/cds/aotClassInitializer.cpp line 348: > >> 346: } >> 347:

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-10-31 Thread Dan Heidinga
On Thu, 31 Oct 2024 02:23:24 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v5]

2024-10-30 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-10-30 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-30 Thread Ioi Lam
On Fri, 25 Oct 2024 18:14:38 GMT, Ashutosh Mehra wrote: >> src/hotspot/share/classfile/systemDictionaryShared.cpp line 685: >> >>> 683: InstanceKlass* ik = InstanceKlass::cast(k); >>> 684: >>> 685: if (SafepointSynchronize::is_at_safepoint()) { >> >> Why is this piece of block required

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-30 Thread Ioi Lam
On Fri, 25 Oct 2024 15:02:30 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8342907: Implement AOT testing mode for jtreg tests (authored by >> @katyapav) >> - disable test that fails with hotsp

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-30 Thread Ioi Lam
On Wed, 30 Oct 2024 19:11:46 GMT, Ioi Lam wrote: >> A thought for a possible cleanup, after this PR is done… >> >> The scratch mirror logic had me… scratching my head. It seems to me that a >> more descriptive name would make the code explain itself better. I suggest >> (for a future cleanup

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-30 Thread Ioi Lam
On Thu, 24 Oct 2024 06:14:18 GMT, John R Rose wrote: > A thought for a possible cleanup, after this PR is done… > > The scratch mirror logic had me… scratching my head. It seems to me that a > more descriptive name would make the code explain itself better. I suggest > (for a future cleanup) c

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-28 Thread Andrey Turbanov
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-25 Thread Ashutosh Mehra
On Fri, 25 Oct 2024 18:08:17 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8342907: Implement AOT testing mode for jtreg tests (authored by >> @katyapav) >> - disable test that fails with hotsp

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-25 Thread Ashutosh Mehra
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-25 Thread Ashutosh Mehra
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-25 Thread Ashutosh Mehra
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-24 Thread John R Rose
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v3]

2024-10-24 Thread Dan Heidinga
On Wed, 23 Oct 2024 04:46:51 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-24 Thread John R Rose
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-23 Thread John R Rose
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-23 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v3]

2024-10-22 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v2]

2024-10-22 Thread Chen Liang
On Tue, 22 Oct 2024 20:35:38 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v2]

2024-10-22 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking

2024-10-22 Thread Vladimir Kozlov
On Tue, 22 Oct 2024 16:19:48 GMT, Ioi Lam wrote: > This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://gith

RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking

2024-10-22 Thread Ioi Lam
This is an implementation of [JEP 483: Ahead-of-Time Class Loading & Linking](https://openjdk.org/jeps/483). Note: this is a combined PR of the following individual PRs - https://github.com/openjdk/jdk/pull/20516 - https://github.com/openjdk/jdk/pull/20517 - https://github.com/openjdk/jdk/pu