On Thu, 4 Apr 2024 07:54:16 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
On Thu, 4 Apr 2024 16:16:41 GMT, Vladimir Kozlov wrote:
>> I don't think that holds if the 'n' is pronounced the way nmethod is
>> pronounced.
>
> `grep` shows that we have both cases but `an nmethod` is used more.
I will fix it here as you suggested but I am not touching other places.
---
On Thu, 4 Apr 2024 16:03:12 GMT, Stefan Karlsson wrote:
>> Quote: "an" goes before words that begin with vowels.
>
> I don't think that holds if the 'n' is pronounced the way nmethod is
> pronounced.
`grep` shows that we have both cases but `an nmethod` is used more.
-
PR Review C
On Thu, 4 Apr 2024 07:51:47 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
On Thu, 4 Apr 2024 15:56:34 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/gc/shared/gcBehaviours.hpp line 31:
>>
>>> 29: #include "oops/oopsHierarchy.hpp"
>>> 30:
>>> 31: // This is the behaviour for checking if a nmethod is unloading
>>
>> Maybe this should be *an* nmethod?
>
> Quote: "an"
On Thu, 4 Apr 2024 07:31:24 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
On Thu, 4 Apr 2024 07:26:21 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
On Thu, 4 Apr 2024 00:05:20 GMT, Vladimir Kozlov wrote:
>> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
>> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
>> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>> imp
On Thu, 4 Apr 2024 00:05:20 GMT, Vladimir Kozlov wrote:
>> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
>> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
>> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>> imp
On Thu, 4 Apr 2024 00:05:20 GMT, Vladimir Kozlov wrote:
>> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
>> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
>> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>> imp
> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
> implementation in JDK 9. The code was left in HotSpot assuming it
11 matches
Mail list logo
