Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v4]

2023-08-10 Thread Chris Plummer
On Thu, 10 Aug 2023 07:17:04 GMT, Kimura Yukihiro wrote: > Can I type "integrate" or should I wait until some labels are added on JBS? I added the `noreg-self` label, which means it is test bug, and assigned the CR to you. You can integrate now. - PR Comment: https://git.openjdk.o

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v4]

2023-08-10 Thread Kimura Yukihiro
On Tue, 8 Aug 2023 23:43:00 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the svc jtreg test does not pass on localized Windows platform. >> Testing: >> all serviceability area tests (jdk_svc group). >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v4]

2023-08-08 Thread Chris Plummer
On Tue, 8 Aug 2023 23:43:00 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the svc jtreg test does not pass on localized Windows platform. >> Testing: >> all serviceability area tests (jdk_svc group). >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v3]

2023-08-08 Thread Kimura Yukihiro
On Tue, 8 Aug 2023 23:17:27 GMT, Chris Plummer wrote: >> Kimura Yukihiro has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merge master >> - 8313854: Some tests in serviceability area fail on localized Windo

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v4]

2023-08-08 Thread Kimura Yukihiro
> I would like to fix this issue > because the svc jtreg test does not pass on localized Windows platform. > Testing: > all serviceability area tests (jdk_svc group). > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request incremental

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v3]

2023-08-08 Thread Chris Plummer
On Tue, 8 Aug 2023 23:04:43 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the svc jtreg test does not pass on localized Windows platform. >> Testing: >> all serviceability area tests (jdk_svc group). >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v3]

2023-08-08 Thread Alex Menkov
On Tue, 8 Aug 2023 23:04:43 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the svc jtreg test does not pass on localized Windows platform. >> Testing: >> all serviceability area tests (jdk_svc group). >> >> Could anyone review the fix please? >> >> Thanks, >> Kimura

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v3]

2023-08-08 Thread Kimura Yukihiro
> I would like to fix this issue > because the svc jtreg test does not pass on localized Windows platform. > Testing: > all serviceability area tests (jdk_svc group). > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request with a new

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v2]

2023-08-08 Thread Chris Plummer
On Tue, 8 Aug 2023 11:27:55 GMT, Kimura Yukihiro wrote: > Hello Chris, I realized that my fix conflicted to another fix. Yes, due to my changes you now have a merge conflict you'll need to resolve, and that will involve reworking your fix. - PR Review Comment: https://git.openjdk.

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v2]

2023-08-08 Thread Kimura Yukihiro
On Tue, 8 Aug 2023 09:52:53 GMT, Kimura Yukihiro wrote: >> test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 153: >> >>> 151: long startTime = System.currentTimeMillis(); >>> 152: try { >>> 153: ProcessBuilder pb = new >>> ProcessBuilder(JDKToolFinder.getTestJDKT

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v2]

2023-08-08 Thread Kimura Yukihiro
On Mon, 7 Aug 2023 21:51:39 GMT, Chris Plummer wrote: >> Kimura Yukihiro has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313854: Some tests in serviceability area fail on localized Windows >> platform > > test/jdk/sun/tools/jhsdb/JShel

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform [v2]

2023-08-08 Thread Kimura Yukihiro
> I would like to fix this issue > because the svc jtreg test does not pass on localized Windows platform. > Testing: > all serviceability area tests (jdk_svc group). > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request incremental

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform

2023-08-07 Thread Chris Plummer
On Mon, 7 Aug 2023 02:37:15 GMT, Kimura Yukihiro wrote: > I would like to fix this issue > because the svc jtreg test does not pass on localized Windows platform. > Testing: > all serviceability area tests (jdk_svc group). > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro

RFR: 8313854: Some tests in serviceability area fail on localized Windows platform

2023-08-06 Thread Kimura Yukihiro
I would like to fix this issue because the svc jtreg test does not pass on localized Windows platform. Testing: all serviceability area tests (jdk_svc group). Could anyone review the fix please? Thanks, Kimura Yukihiro - Commit messages: - 8313854: Some tests in serviceability a