Re: RFR: 8308000: add PopFrame support for virtual threads [v8]

2023-05-22 Thread Serguei Spitsyn
On Sat, 20 May 2023 00:30:17 GMT, Serguei Spitsyn wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended

Re: RFR: 8308000: add PopFrame support for virtual threads [v8]

2023-05-20 Thread Alan Bateman
On Sat, 20 May 2023 00:30:17 GMT, Serguei Spitsyn wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended

Re: RFR: 8308000: add PopFrame support for virtual threads [v7]

2023-05-19 Thread Serguei Spitsyn
On Thu, 18 May 2023 05:57:01 GMT, Serguei Spitsyn wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended

Re: RFR: 8308000: add PopFrame support for virtual threads [v8]

2023-05-19 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads [v7]

2023-05-19 Thread Leonid Mesnik
On Thu, 18 May 2023 05:57:01 GMT, Serguei Spitsyn wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended

Re: RFR: 8308000: add PopFrame support for virtual threads [v7]

2023-05-17 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 19:06:24 GMT, Chris Plummer wrote: > The following problem listed JDI tests are all passing now. However, I don't > think there are any negative tests for OPAQUE_FRAME and THREAD_NOT_SUSPENDED. > If I can't find any I'll need to write them. Okay. Thank you for sharing this.

Re: RFR: 8308000: add PopFrame support for virtual threads [v6]

2023-05-17 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads [v5]

2023-05-17 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads [v4]

2023-05-17 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads [v3]

2023-05-17 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads [v2]

2023-05-17 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 18:59:38 GMT, Chris Plummer wrote: > serviceability/jvmti/vthread/BoundVThreadTest/BoundVThreadTest.java and > serviceability/jvmti/vthread/VThreadUnsupportedTest/VThreadUnsupportedTest.java > are failing with: > > `PopFrame failed: expected JVMTI_ERROR_OPAQUE_FRAME instead

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 18:59:38 GMT, Chris Plummer wrote: > VThreadUnsupportedTest - PR Comment: https://git.openjdk.org/jdk/pull/14002#issuecomment-1551136595

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Wed, 17 May 2023 09:08:32 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnv.cpp line 1896: >> >>> 1894: } >>> 1895: } else { >>> 1896: if (java_thread != current_thread && !java_thread->is_suspended() >>> && >> >> This branch checks the state when the thread is platf

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 23:57:45 GMT, Leonid Mesnik wrote: > It is also unclear how popFrame works if the the underlying frame is > jdk.internal.vm.Continuation.enterSpecial(). Would it just return some error? Good question. Let me check it. - PR Comment: https://git.openjdk.org/jdk/p

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 23:42:16 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 22:18:17 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 22:04:26 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Wed, 17 May 2023 00:22:08 GMT, Chris Plummer wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 23:42:52 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 23:35:09 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Wed, 17 May 2023 01:03:52 GMT, David Holmes wrote: >> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/PopFrameTest.java >> line 62: >> >>> 60: static final int FAILED = 2; >>> 61: >>> 62: static void log(String str) { System.out.println(str); } >> >> Better to flush sy

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 23:36:57 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 23:15:36 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-17 Thread Serguei Spitsyn
On Tue, 16 May 2023 22:52:41 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Serguei Spitsyn
On Tue, 16 May 2023 18:56:05 GMT, Chris Plummer wrote: > You still have the following test problem listed. It seems to be passing now: > > `vmTestbase/nsk/jvmti/PopFrame/popframe004/TestDescription.java 8300708 > generic-all` You probably mean when executed in a virtual thread mode, right? As

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread David Holmes
On Tue, 16 May 2023 23:27:37 GMT, Leonid Mesnik wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended an

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Chris Plummer
On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn wrote: > This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Leonid Mesnik
On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn wrote: > This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Chris Plummer
On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn wrote: > This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Chris Plummer
On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn wrote: > This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Chris Plummer
On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn wrote: > This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and

Re: RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Chris Plummer
On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn wrote: > This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and

RFR: 8308000: add PopFrame support for virtual threads

2023-05-16 Thread Serguei Spitsyn
This enhancement adds PopFrame support for virtual threads. CSR: https://bugs.openjdk.org/browse/JDK-8308001: add PopFrame support for virtual threads Testing: New test was developed: `serviceability/vthread/PopFrameTest`. Submitted mach5 tiers 1-6 are good. TBD: rerun mach5 tiers 1-6 at the end