On Tue, 16 May 2023 08:12:21 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved): https://bugs.openjdk.org/browse/JDK-8308001: add PopFrame > support for virtual threads > > Testing: > New test was developed: `serviceability/vthread/PopFrameTest`. > Submitted mach5 tiers 1-6 are good. > TBD: rerun mach5 tiers 1-6 at the end of review again if necessary. The following problem listed JDI tests are all passing now. However, I don't think there are any negative tests for OPAQUE_FRAME and THREAD_NOT_SUSPENDED. If I can't find any I'll need to write them. vmTestbase/nsk/jdb/pop_exception/pop_exception001/pop_exception001.java 8285414 generic-all vmTestbase/nsk/jdi/VirtualMachine/redefineClasses/redefineclasses002/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/Scenarios/invokeMethod/popframes001/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc01x002/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc02x001/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc02x002/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc04x001/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc04x002/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc06x001/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc08x001/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x002/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/ThreadReference/popFrames/popframes002/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/ThreadReference/popFrames/popframes003/TestDescription.java 8285414 generic-all vmTestbase/nsk/jdi/ThreadReference/popFrames/popframes004/TestDescription.java 8285414 generic-all com/sun/jdi/PopAndStepTest.java 8285422 generic-all com/sun/jdi/PopAsynchronousTest.java 8285422 generic-all com/sun/jdi/PopSynchronousTest.java 8285422 generic-all com/sun/jdi/PopAndInvokeTest.java 8305632 generic-all ------------- PR Comment: https://git.openjdk.org/jdk/pull/14002#issuecomment-1550209783
