On Wed, 17 May 2023 09:08:32 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiEnv.cpp line 1896: >> >>> 1894: } >>> 1895: } else { >>> 1896: if (java_thread != current_thread && !java_thread->is_suspended() >>> && >> >> This branch checks the state when the thread is platform OR current, that >> logic seems a little bit messy. Would not be better to clearly separate >> virtual and platform threads verification? (Also, it is unclear, we need to >> check platform threads here now). >> Might be some comments are needed? > > You are right, thanks. Fixed now. Good comment, thanks.But, please, see previous answer (fixed now). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14002#discussion_r1196198599