Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-24 Thread Serguei Spitsyn
On Sat, 22 Apr 2023 00:09:27 GMT, Serguei Spitsyn wrote: >> For the JDI tests I added, I execute them in both modes, with the >> appropriate adjustments to account for the errors we except for virtual >> threads. We should be testing to make sure that StopThread works with >> platform threads

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 18:58:22 GMT, Chris Plummer wrote: >> Do you ask this question to check if we want to extend this test to provide >> coverage for platform threads as well? >> >> The support of platform threads is much simpler. The JVMTI `StopThread` >> never returns the `THREAD_NOT_SUSPEND

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Chris Plummer
On Fri, 21 Apr 2023 18:41:41 GMT, Serguei Spitsyn wrote: >> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java >> line 89: >> >>> 87: log("\nMain #A: method A() must be blocked on entering a >>> synchronized statement"); >>> 88: synchronized (Tes

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 16:34:34 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrections for BoundVirtualThread and test typos > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTes

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 16:33:06 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrections for BoundVirtualThread and test typos > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTes

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Chris Plummer
On Fri, 21 Apr 2023 08:09:55 GMT, Serguei Spitsyn wrote: >> This enhancement adds support of virtual threads to the JVMTI `StopThread` >> function. >> In preview releases before this enhancement the StopThread returned the >> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads. >>

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
> This enhancement adds support of virtual threads to the JVMTI `StopThread` > function. > In preview releases before this enhancement the StopThread returned the > JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads. > > The `StopThread` supports sending an asynchronous exception t