Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-20 Thread Boris Ulasevich
On Tue, 17 Jan 2023 08:57:35 GMT, Fredrik Bredberg wrote: > Hi @bulasevich, can you verify that this PR works on Arm32? ARM32 part LGTM. Test results are fine. Thanks! - PR: https://git.openjdk.org/jdk/pull/11902

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-20 Thread Robbin Ehn
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote: >> Fredrik Bredberg has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> com

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-18 Thread Martin Doerr
On Wed, 18 Jan 2023 15:46:22 GMT, Fredrik Bredberg wrote: >> The code uses &sp()[R12_scratch2]. I think your comment is confusing. Please >> remove it or write something comprehensive. E.g. save R18_locals in >> compressed format relative to the new top frame's FP (= current SP). > > See what y

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-18 Thread Fredrik Bredberg
On Wed, 18 Jan 2023 05:07:38 GMT, Martin Doerr wrote: >> My intention was to show how the contents of R18_locals (the absolute >> address to locals) can be recreated by using R12_scratch2 as an index from >> the frame pointer. Before we stored R18_locals in the stackframe, now we >> store R12_

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-18 Thread Patricio Chilano Mateo
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-18 Thread Andrew Haley
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-18 Thread Fredrik Bredberg
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote: > > Implementation of relativized locals in interpreter frames for x86. x64, > > arm, aarch64, ppc64le and riscv. Not relativized locals on zero and s390 > > but done some changes to cope with the changed generic code. Tested > > tier1-tier

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Martin Doerr
On Tue, 17 Jan 2023 17:02:04 GMT, Fredrik Bredberg wrote: >> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 1035: >> >>> 1033: __ sub(R12_scratch2, R18_locals, R1_SP); >>> 1034: __ srdi(R12_scratch2, R12_scratch2, >>> Interpreter::logStackElementSize); >>> 1035: // Now &fp(

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Andrew Haley
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Fredrik Bredberg
On Tue, 17 Jan 2023 13:32:47 GMT, Martin Doerr wrote: >> Fredrik Bredberg has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> com

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Martin Doerr
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Robbin Ehn
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Fredrik Bredberg
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Fredrik Bredberg
> Implementation of relativized locals in interpreter frames for x86. x64, arm, > aarch64, ppc64le and riscv. > Not relativized locals on zero and s390 but done some changes to cope with > the changed generic code. > Tested tier1-tier8 on supported platforms. The rest was sanity tested using > Q