Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-14 Thread Coleen Phillimore
On Wed, 14 Dec 2022 00:51:34 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add a space > > src/hotspot/share/oops/instanceKlassMiscStatus.cpp line 64: > >> 62: #ifdef ASSERT >> 63: void In

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-14 Thread Coleen Phillimore
On Tue, 13 Dec 2022 22:00:04 GMT, Coleen Phillimore wrote: >> These access flags were implemented to enable passing access flag values >> from Method* to InstanceKlass*, but only covered one flag. Towards only >> have access flags represent read-only flags in the class file, remove this >> an

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v3]

2022-12-14 Thread Coleen Phillimore
> These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pass has_localvariable_table up to InstanceKlass in classfile p

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-13 Thread David Holmes
On Tue, 13 Dec 2022 22:00:04 GMT, Coleen Phillimore wrote: >> These access flags were implemented to enable passing access flag values >> from Method* to InstanceKlass*, but only covered one flag. Towards only >> have access flags represent read-only flags in the class file, remove this >> an

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-13 Thread Coleen Phillimore
On Tue, 13 Dec 2022 20:42:04 GMT, Daniel D. Daugherty wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add a space > > src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4376: > >> 4374: if (scratch_clas

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Coleen Phillimore
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-13 Thread Coleen Phillimore
> These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pass has_localvariable_table up to InstanceKlass in classfile p

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Daniel D . Daugherty
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Coleen Phillimore
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Serguei Spitsyn
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Coleen Phillimore
These access flags were implemented to enable passing access flag values from Method* to InstanceKlass*, but only covered one flag. Towards only have access flags represent read-only flags in the class file, remove this and pass has_localvariable_table up to InstanceKlass in classfile parsing,