On Wed, 6 Jul 2022 01:24:09 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Do not remove Forte::register_stub as it is used on Linux as well
>
> Cleanup looks good! Thanks.
Thanks @dholmes-ora, @sspi
On Fri, 8 Jul 2022 23:06:03 GMT, Ioi Lam wrote:
>> src/hotspot/share/runtime/sharedRuntime.cpp line 2700:
>>
>>> 2698: if (JvmtiExport::should_post_dynamic_code_generated()) {
>>> 2699: JvmtiExport::post_dynamic_code_generated(blob_id,
>>> new_adapter->content_begin(), new_adapter->co
On Fri, 8 Jul 2022 22:53:49 GMT, Serguei Spitsyn wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Do not remove Forte::register_stub as it is used on Linux as well
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 270
On Wed, 6 Jul 2022 17:50:54 GMT, Ioi Lam wrote:
>> `Forte::register_stub()` should be called only when the JVm is being
>> instrumented by Forte (aka "Oracle Developer Studio")
>>
>> https://www.oracle.com/tools/developerstudio/downloads/developer-studio-jsp.html
>>
>> We currently always form
On Fri, 8 Jul 2022 18:35:38 GMT, Ioi Lam wrote:
>> If the answer to whether it's enabled is something you want to be fast, and
>> doesn't change, maybe make it check a variable?
>
> The code in the `Forte` class, as well as the non-trivial of
> `AsyncGetCallTrace()` in forte.cpp, are inside `#i
On Wed, 6 Jul 2022 17:50:54 GMT, Ioi Lam wrote:
>> `Forte::register_stub()` should be called only when the JVm is being
>> instrumented by Forte (aka "Oracle Developer Studio")
>>
>> https://www.oracle.com/tools/developerstudio/downloads/developer-studio-jsp.html
>>
>> We currently always form
On Thu, 7 Jul 2022 15:12:49 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/forte.hpp line 32:
>>
>>> 30: class Forte : AllStatic {
>>> 31: public:
>>> 32:static bool is_enabled() NOT_JVMTI_RETURN_(false);
>>
>> I don't think the rest of this forte code is disabled by JVMTI.
>
> I
On Wed, 6 Jul 2022 19:09:09 GMT, Coleen Phillimore wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Do not remove Forte::register_stub as it is used on Linux as well
>
> src/hotspot/share/prims/forte.hpp line 32:
>
>> 3
On Wed, 6 Jul 2022 17:50:54 GMT, Ioi Lam wrote:
>> `Forte::register_stub()` should be called only when the JVm is being
>> instrumented by Forte (aka "Oracle Developer Studio")
>>
>> https://www.oracle.com/tools/developerstudio/downloads/developer-studio-jsp.html
>>
>> We currently always form
