Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v8]

2025-02-13 Thread John R Rose
On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v6]

2025-02-12 Thread John R Rose
On Wed, 12 Feb 2025 16:28:32 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Sat, 16 Nov 2024 02:48:09 GMT, John R Rose wrote: >> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains nine commits: >> >> - Handle merge conflicts in new resolve_instance_class c

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v14]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v12]

2024-11-14 Thread John R Rose
On Fri, 15 Nov 2024 05:48:27 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-24 Thread John R Rose
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-24 Thread John R Rose
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v4]

2024-10-23 Thread John R Rose
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8339112: Move JVM Klass flags out of AccessFlags

2024-08-29 Thread John R Rose
On Mon, 26 Aug 2024 23:54:22 GMT, Coleen Phillimore wrote: > Move JVM implementation access flags that are not specified by the classfile > format into Klass so we can shrink AccessFlags to u2 in a future change. > > Tested with tier1-7. > > NOTE: there are arm, ppc and s390 changes to this th

Re: RFR: 8324241: Always record evol_method deps to avoid excessive method flushing [v2]

2024-01-22 Thread John R Rose
On Mon, 22 Jan 2024 23:26:08 GMT, Evgeny Astigeevich wrote: >> Volker Simonis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Guard the feature with a diagnostic option and update the comments in the >> code > > src/hotspot/share/runti

Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v7]

2023-10-30 Thread John R Rose
On Sun, 29 Oct 2023 07:51:48 GMT, Kim Barrett wrote: >> @dholmes-ora Yes it helps avoid copying, especially if the copy constructor >> is non-trivial. And I think it is more idiomatic in C++ to use references >> here. > > Using a reference here leads to unnecessary overhead when `E` is small an

Re: RFR: 8306474: Move InstanceKlass read-only flags

2023-04-19 Thread John R Rose
On Wed, 19 Apr 2023 23:27:10 GMT, John R Rose wrote: >> Moved three read-only InstanceKlass flags out of AccessFlags to >> InstanceKlassFlags, and removed unused and unneeded SA code. >> Tested with tier1-4. > > src/hotspot/share/oops/instanceKlassFlags.hpp lin

Re: RFR: 8306474: Move InstanceKlass read-only flags

2023-04-19 Thread John R Rose
On Wed, 19 Apr 2023 22:46:55 GMT, Coleen Phillimore wrote: > Moved three read-only InstanceKlass flags out of AccessFlags to > InstanceKlassFlags, and removed unused and unneeded SA code. > Tested with tier1-4. Reviewed. I like to see access flags being slowly emptied out. It was a not-so-go

Re: RFR: 8291555: Replace stack-locking with fast-locking [v8]

2022-11-14 Thread John R Rose
On Fri, 28 Oct 2022 09:32:58 GMT, Roman Kennke wrote: >> This change replaces the current stack-locking implementation with a >> fast-locking scheme that retains the advantages of stack-locking (namely >> fast locking in uncontended code-paths), while avoiding the overload of the >> mark word.

Re: RFR: 8291555: Replace stack-locking with fast-locking

2022-11-14 Thread John R Rose
On Fri, 28 Oct 2022 01:47:23 GMT, David Holmes wrote: > So the data structure for lock records (per thread) could consist of a series > of distinct values [ A B C ] and each of the values could be repeated, but > only adjacently: [ A A A B C C ] for example. > @rose00 why only adjacently? Neste

Re: RFR: 8291555: Replace stack-locking with fast-locking [v7]

2022-10-27 Thread John R Rose
On Mon, 24 Oct 2022 11:01:01 GMT, Robbin Ehn wrote: > Secondly, a question/suggestion: Many recursive cases do not interleave > locks, meaning the recursive enter will happen with the lock/oop top of lock > stack already. Why not peak at top lock/oop in lock-stack if the is current > just push

Integrated: 8292758: put support for UNSIGNED5 format into its own header file

2022-09-08 Thread John R Rose
On Mon, 29 Aug 2022 18:20:42 GMT, John R Rose wrote: > Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > str

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-08 Thread John R Rose
On Sat, 3 Sep 2022 07:48:50 GMT, Dean Long wrote: >> John R Rose has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two addi

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v5]

2022-09-06 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has upd

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v4]

2022-09-06 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has upd

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v3]

2022-09-03 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has upd

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-02 Thread John R Rose
On Fri, 2 Sep 2022 23:28:38 GMT, Dean Long wrote: > I suggest splitting this up into the straight-forward refactor (without the > excluded bytes change), then adding excluded bytes as a follow-up. Yes, that is a slight change. Splitting is not necessary for the reason you mention because this

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-01 Thread John R Rose
On Fri, 2 Sep 2022 00:04:17 GMT, John R Rose wrote: >> Refactor code from inside of CompressedStream into its own unit. >> >> This code is likely to be used in future refactorings, such as JDK-8292818 >> (replace 96-bit representation for field metadata with va

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-01 Thread John R Rose
> Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gtests. John R Rose has updated th

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file

2022-09-01 Thread John R Rose
On Mon, 29 Aug 2022 18:20:42 GMT, John R Rose wrote: > Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > str

RFR: 8292758: put support for UNSIGNED5 format into its own header file

2022-09-01 Thread John R Rose
Refactor code from inside of CompressedStream into its own unit. This code is likely to be used in future refactorings, such as JDK-8292818 (replace 96-bit representation for field metadata with variable-sized streams). Add gtests. - Commit messages: - 8292758: put support for UNS