On Wed, 5 Feb 2025 14:41:39 GMT, Albert Mingkun Yang wrote:
>> Here is an attempt to simplify GCLocker implementation for Serial and
>> Parallel.
>>
>> GCLocker prevents GC when Java threads are in a critical region (i.e.,
>> calling JNI critical APIs). JDK-7129164 introduces an optimization t
On Tue, 4 Feb 2025 09:47:20 GMT, Thomas Schatzl wrote:
> * Idk if GCLocker JFR events need to be available in metadata.xml if the VM
> does not actually ever send it. I think it does not.
> Maybe it is used to decode from old recordings, may be worth asking e.g.
> @egahlin .
If the event is
On Tue, 14 Jan 2025 16:51:51 GMT, Coleen Phillimore wrote:
> Thanks Erik. Trivial?
Yes!
-
PR Comment: https://git.openjdk.org/jdk/pull/23109#issuecomment-2590556159
On Tue, 14 Jan 2025 16:35:32 GMT, Coleen Phillimore wrote:
> Please review this change to replace SIZE_FORMAT with %zu in the jfr
> directory. Most were done with a script with no hand-editing.
>
> Tested just now with tier1-4 on x86 and aarch64.
Marked as reviewed by egahlin (Reviewer).
---
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo
wrote:
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes hav
On Tue, 5 Nov 2024 01:40:15 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Tue, 22 Oct 2024 16:22:20 GMT, Roman Kennke wrote:
> @egahlin / @mgronlun could you please review the JFR parts of this PR? One
> change is for getting the right prototype header, the other is for avoiding
> an endless loop/assert in a corner case.
JFR changes look reasonable.
On Tue, 22 Oct 2024 16:19:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 10 Oct 2024 08:51:38 GMT, Kevin Walls wrote:
>> DiagnosticCommandImpl should only publish parameter types in a known
>> standard set, and use "STRING" on anything else.
>> e.g. We can say "FILE" in the help output for jcmd, as that's for humans,
>> but the MBean parameter info should co
On Tue, 17 Sep 2024 14:32:22 GMT, Kevin Walls wrote:
>> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
>> should be changed to INT.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> No comma in:
On Fri, 16 Aug 2024 19:27:47 GMT, Chris Plummer wrote:
> I wonder if it is possible to do this without the addition of FILE. Maybe
> most of the code can be shared, but we need a bit of dcmd specific code to
> invoke this filename expansion code.
In JFR and JMC we have made the distinction bet
On Tue, 30 Jul 2024 14:33:10 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
>> enabling jcmd diagnostic commands that issue an output file to accept the
>> `%p` pattern in the file name and substitute it for the PID.
On Fri, 9 Aug 2024 19:25:29 GMT, Erik Gahlin wrote:
>> Thanks, yes should have made this clearer and yes will follow up on the
>> additional commands, we should transition them to the same language.
>
> JFR.dump, JFR.start, and JFR.stop are written in Java and have separated f
On Fri, 9 Aug 2024 18:53:28 GMT, Kevin Walls wrote:
>> Ok. I see now that
>> [JDK-8334492](https://bugs.openjdk.org/browse/JDK-8334492) made the STRING
>> -> FILE change, so yes the docs should be consistent, but I think we need a
>> new CR filed to cleanup JFR dcmds, which continue to use STR
On Wed, 17 Jul 2024 11:21:04 GMT, Markus Grönlund wrote:
> 8334781: JFR crash: assert(JfrTraceIdBits::load(klass)) &
> ((JfrTraceIdEpoch::this_epoch_method_and_class_bits( != 0))) failed:
> invariant
Marked as reviewed by egahlin (Reviewer).
-
PR Review: https://git.open
On Sat, 13 Jul 2024 14:47:21 GMT, Markus Grönlund wrote:
> Greetings,
>
> Please help review this adjustment, which fixes rare situations where methods
> that have been retransformed or redefined can be perceived as being tagged by
> JFR when they, in fact, are not. The fix unconditionally set
On Thu, 4 Jul 2024 10:54:22 GMT, Erik Gahlin wrote:
> 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
This pull request has now been integrated.
Changeset: 90d5b5b4
Author: Erik Gahlin
URL:
https://git.openjdk.org/jdk/commit/90d5b5b4c497ac99d0e2ade689b6459ff
On Thu, 4 Jul 2024 10:51:48 GMT, Erik Gahlin wrote:
> 8322812: Manpage for jcmd is missing JFR.view command
This pull request has now been integrated.
Changeset: 10b28bab
Author: Erik Gahlin
URL:
https://git.openjdk.org/jdk/commit/10b28babe53821fcdeef3a1aa0712feb7cd67529
St
8324089: Fix typo in the manual page for "jcmd" (man jcmd)
-
Commit messages:
- Backport 0bb9c76288b5f63fe965c3276bb566cef5f51c50
Changes: https://git.openjdk.org/jdk/pull/20030/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20030&range=00
Issue: https://bugs.openjdk.org
8322812: Manpage for jcmd is missing JFR.view command
-
Commit messages:
- Backport 350f9c1947b0eab3ee233516ceefca1e25de9583
Changes: https://git.openjdk.org/jdk/pull/20028/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20028&range=00
Issue: https://bugs.openjdk.org/brow
On Wed, 3 Jul 2024 12:05:43 GMT, Erik Gahlin wrote:
> Could I have a review of a typo for JFR.start and JFR.dump?
>
> Testing: tier1
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 0bb9c762
Author:Erik Gahlin
URL:
https://git.open
Could I have a review of a typo for JFR.start and JFR.dump?
Testing: tier1
Thanks
Erik
-
Commit messages:
- Initial
Changes: https://git.openjdk.org/jdk/pull/20003/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20003&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
On Fri, 28 Jun 2024 14:51:57 GMT, Erik Gahlin wrote:
> Could I have a review of a change to the jcmd man page?
>
> Testing: tier1
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 350f9c19
Author:Erik Gahlin
URL:
https://git.open
> Could I have a review of a change to the jcmd man page?
>
> Testing: tier1
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incrementally with two additional
commits since the last revision:
- Remove accidentally added file
- Remove fix of typo. It will be hand
Could I have a review of a change to the jcmd man page? A typo was also fixed
for JFR.start.
Testing: tier1
Thanks
Erik
-
Commit messages:
- Don't touch version
- Review feedback
- Initial
Changes: https://git.openjdk.org/jdk/pull/19942/files
Webrev: https://webrevs.openjdk.o
On Tue, 19 Mar 2024 17:58:46 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumu
On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is no such
>> typo in this repository. So I
On Thu, 8 Feb 2024 13:46:40 GMT, Markus Grönlund wrote:
> Greetings,
>
> The following adjustments fix the intermittent issues with incomplete tag
> sets for a chunk. The situations are pretty subtle:
>
> 1. A situation can occur where an event is emitted during the event
> instrumentation ca
On Mon, 30 Oct 2023 16:09:50 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is n
On Mon, 30 Oct 2023 08:46:08 GMT, Taizo Kurashige wrote:
> Hi,
>
> I fixed the typos for JFR.start and JFR.dump.
> Acconding to issue's description, there is some typo in JFR.stop
> documentation, but I couldn't find that. I confirmed that there is no such
> typo in this repository. So I thoug
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote:
> Main changes are to use 21 instead of 21-ea. In addition the following files
> contain additional updates from the closed sources:
>
> - src/java.base/share/man/java.1
>
> [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat
On Tue, 18 Apr 2023 14:22:21 GMT, Markus Grönlund wrote:
> Greetings,
>
> With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much
> refactoring was done to the JVMTI code concerning agents. However, some
> platforms do not have JVMTI support, and tier5 of testing builds an embedd
On Thu, 1 Dec 2022 18:00:11 GMT, Joe Darcy wrote:
>> Similar to an update recently done for langtools tests, update the libraries
>> regression tests to take advantage of the @enablePreview jtreg feature.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit sinc
33 matches
Mail list logo
