On Fri, 9 Aug 2024 19:25:29 GMT, Erik Gahlin <[email protected]> wrote:
>> Thanks, yes should have made this clearer and yes will follow up on the
>> additional commands, we should transition them to the same language.
>
> JFR.dump, JFR.start, and JFR.stop are written in Java and have separated from
> the Hotspot dcmd infrastructure. For example, this is how filename expansion
> is handled by JFR.start (and -XX:StartFlightRecording):
>
> String path = expandFilename(parser.getOption("filename"));
>
> Default values are hardwired into the command and the help is custom. The
> JFR.start command allows additional option, like event settings. that are not
> "DCmdArguments". One could replace "STRING" with "FILE", but the only visible
> impact would be the metadata provided by the DiagnosticCommandMBean.
I filed an issue:
https://bugs.openjdk.org/browse/JDK-8338405
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20401#discussion_r1717100383
