On Fri, 9 Aug 2024 18:53:28 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Ok. I see now that >> [JDK-8334492](https://bugs.openjdk.org/browse/JDK-8334492) made the STRING >> -> FILE change, so yes the docs should be consistent, but I think we need a >> new CR filed to cleanup JFR dcmds, which continue to use STRING. This >> probably should have been done with >> [JDK-8334492](https://bugs.openjdk.org/browse/JDK-8334492). > > Thanks, yes should have made this clearer and yes will follow up on the > additional commands, we should transition them to the same language. JFR.dump, JFR.start, and JFR.stop are written in Java and have separated from the Hotspot dcmd infrastructure. For example, this is how file expansion is handled by JFR.start (and -XX:StartFlightRecording): String path = expandFilename(parser.getOption("filename")); Default values are hardwired into the command and the help is custom. The command allows additional options, like event settings. that are not "DCmdArguments". One could replace "STRING" with "FILE", but the only visible impact would be the metadata provided by the DiagnosticCommandMBean. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20401#discussion_r1712036951
