On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 12 Nov 2024 15:02:12 GMT, Sean Mullan wrote:
>> I can add it back if it is more convenient and readable to have the `@see`
>> tag.
>
> This can be taken care of later after integration.
Agreed!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1838282
On Fri, 8 Nov 2024 21:01:57 GMT, Phil Race wrote:
>>> I'd not looked at this test before but when I do the thing I noticed is
>>> that createPrivateValue is no longer used. But I don't see a problem with
>>> keeping the rest of the test.
>>
>> @prrace Do I understand correctly that _“`createPr
On Tue, 29 Oct 2024 17:06:08 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/MouseInfo.java line 68:
>>
>>> 66: * @throws SecurityException if a security manager exists and its
>>> 67: *{@code checkPermission} method doesn't allow the
>>> operation
>
On Tue, 29 Oct 2024 12:56:25 GMT, Sean Mullan wrote:
>> test/jdk/javax/xml/crypto/dsig/keyinfo/KeyInfo/Marshal.java line 30:
>>
>>> 28: * @modules java.xml.crypto/org.jcp.xml.dsig.internal.dom
>>> 29: * @compile -XDignore.symbol.file Marshal.java
>>> 30: * @run main/othervm/java.security.poli
On Mon, 28 Oct 2024 14:35:57 GMT, Sean Mullan wrote:
>> That and possibly rename the test because now it does not have anything to
>> do with the SecurityException. Now we only check that providing an empty
>> file causes the InvalidMidiDataException so EmptySoundBankTest or something
>> to th
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 28 Oct 2024 14:08:46 GMT, Sean Mullan wrote:
>> src/java.desktop/share/classes/java/awt/Font.java line 1612:
>>
>>> 1610: * obtained. The {@code String} value of this property is then
>>> 1611: * interpreted as a {@code Font} object according to the
>>> 1612: * specificat
On Mon, 28 Oct 2024 18:07:26 GMT, Harshitha Onkar wrote:
>> I'd not looked at this test before but when I do the thing I noticed is that
>> createPrivateValue is no longer used.
>> But I don't see a problem with keeping the rest of the test.
>
> Test updated in sandbox -
> https://github.com/op
On Thu, 24 Oct 2024 20:57:50 GMT, Sean Mullan wrote:
>> @honkar-jdk I'm inclined to leave it as because it's not the only method
>> which doesn't have a blank line between `@param` and `@throw` in this file.
>>
>> If it's worth taking care of, we may submit another bug to address it later.
>
>
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 18:30:23 GMT, Harshitha Onkar wrote:
>> The updated test `bug6694823.java` works correctly on Windows and displays
>> its popup over the Windows taskbar — it is expected.
>>
>> The popup had to be moved if the security manager didn't allow to call
>> `setAlwaysOnTop(true)`.
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 17:30:56 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41:
>>
>>> 39: * @bug 6694823
>>> 40: * @summary Checks that popup menu cannot be partially hidden
>>> 41: * by the task bar.
>>
>> I believe this test is irrelev
On Fri, 25 Oct 2024 15:29:40 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/UIDefaults/6622002/bug6622002.java line 1:
>>
>>> 1: /*
>>
>> Again, I'm unsure this test has a value after the security manager is
>> removed. All it ver
On Fri, 25 Oct 2024 15:12:00 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486&
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 21:06:23 GMT, Harshitha Onkar wrote:
>>> It was missed when `-Djava.security.manager=allow` was removed.
>>
>> It wasn't intentional then, was it?
>>
>>> Out of curiosity: does it have any impact on the performance of CI testing
>>> if tests are run in /othervm mode when it
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>>
On Thu, 24 Oct 2024 17:58:55 GMT, Harshitha Onkar wrote:
> It was missed when `-Djava.security.manager=allow` was removed.
It wasn't intentional then, was it?
> Out of curiosity: does it have any impact on the performance of CI testing if
> tests are run in /othervm mode when it is not needed?
On Wed, 23 Oct 2024 02:56:30 GMT, Prasanta Sadhukhan
wrote:
>> Agreed. This is not a "clean up / update tests" task.
>> If it is a change on some lines of code that are updated by the SM changes,
>> then that's fair game, but otherwise only the SM behaviour is part of this
>> task.
>> Anything
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
On Fri, 8 Sep 2023 13:02:07 GMT, Alan Bateman wrote:
> So what about FontConfiguration? Is that something using the class directly
> too?
I think this is not needed either. As far as I can see, the instance of
`FontConfiguration` is created from `doPrivileged`, therefore these two system
prop
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad wrote:
> Yes, iff means if-and-only-if and is used for extra precision in formal
> logic, mathematics.
I've never come across it before. With your explanations, it makes perfect
sense.
-
PR: https://git.openjdk.org/jdk/pull/12826
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Thu, 2 Feb 2023 06:12:20 GMT, Julian Waters wrote:
> Small, trivial change to resolve initialization order reordering in
> constructors, required for
> [JDK-8301659](https://bugs.openjdk.org/browse/JDK-8301659)
Looks good to me.
David's comment sheds some light on why it's needed. I will a
On Thu, 2 Feb 2023 12:12:37 GMT, Kevin Walls wrote:
> Could we say in the bug exactly when this is an issue (maybe it's a certain
> compiler?), and include a copy of the error or warning that is seen?
Yes, I agree. The change is simple enough yet there are no details why it's
needed.
On Wed, 4 Jan 2023 16:35:41 GMT, Michael Ernst wrote:
>> 8299563: Fix typos
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains ten commits:
>
> - Address review feedback
> - Merge ../jdk-openjdk into typos-typos
>
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:29:41 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit c91fdaa19dc06351598bd1c061
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
36 matches
Mail list logo
