On Wed, 8 Jan 2025 05:48:42 GMT, David Holmes wrote:
>> Ramkumar Sunderbabu has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> incorporated review comments
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001.java
>
> Trivial logging message change.
Ramkumar Sunderbabu has updated the pull request incrementally with one
additional commit since the last revision:
incorporated review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22939/files
- new: https://git.openjdk.org/jdk/
Since [JDK-8285417](https://bugs.openjdk.org/browse/JDK-8285417) is now closed
as a dup of [JDK-8347137](https://bugs.openjdk.org/browse/JDK-8347137), its
problem list entry needs to be updated.
-
Commit messages:
- Update CR for VMOutOfMemoryException problem list entry
Changes:
On Tue, 7 Jan 2025 07:58:18 GMT, Ramkumar Sunderbabu
wrote:
> Trivial logging message change.
Changes requested by dholmes (Reviewer).
test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001.java
line 2:
> 1: /*
> 2: * Copyright (c) 2007, 2024, Oracle and/or its affiliates
On Mon, 6 Jan 2025 16:41:21 GMT, Patricio Chilano Mateo
wrote:
> Please review the following fix. In method
> `JvmtiEventControllerPrivate::recompute_thread_enabled()`, we are missing to
> call `leave_interp_only_mode()` for the case where `should_be_interp` is
> computed as false and `state-
On Wed, 8 Jan 2025 00:04:31 GMT, David Holmes wrote:
> Revert "8339113: AccessFlags can be u2 in metadata"
>
> This reverts commit 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1.
>
> The integration of the original change needs to be coordinated with a change
> to Graal so backing out till that is r
On Wed, 8 Jan 2025 00:04:31 GMT, David Holmes wrote:
> Revert "8339113: AccessFlags can be u2 in metadata"
>
> This reverts commit 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1.
>
> The integration of the original change needs to be coordinated with a change
> to Graal so backing out till that is r
On Wed, 8 Jan 2025 00:10:25 GMT, Coleen Phillimore wrote:
>> Revert "8339113: AccessFlags can be u2 in metadata"
>>
>> This reverts commit 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1.
>>
>> The integration of the original change needs to be coordinated with a change
>> to Graal so backing out til
Revert "8339113: AccessFlags can be u2 in metadata"
This reverts commit 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1.
The integration of the original change needs to be coordinated with a change to
Graal so backing out till that is ready.
Thanks
-
Commit messages:
- Revert "8339113:
On Tue, 19 Nov 2024 16:18:48 GMT, Coleen Phillimore wrote:
> Please review this change that makes AccessFlags and modifier_flags u2 types
> and removes the last remnants of Hotspot adding internal access flags. This
> change moves AccessFlags and modifier_flags in Klass to alignment gaps savin
On Tue, 7 Jan 2025 20:59:18 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make more AccessFlags fetches more specific and remove an assert and
>> remove this->s.
>
> src/hotspot/share/classfi
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
On Mon, 6 Jan 2025 16:41:21 GMT, Patricio Chilano Mateo
wrote:
> Please review the following fix. In method
> `JvmtiEventControllerPrivate::recompute_thread_enabled()`, we are missing to
> call `leave_interp_only_mode()` for the case where `should_be_interp` is
> computed as false and `state-
> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
> stepping in some cases.
> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
> `JVMTI_ERROR_DUPLICATE` to make it consistent with the `SetBreakpoint` which
> also returns this error.
>
> The
> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
> specified FramePop event was already requested. This makes it consistent with
> the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to
> add a breakpoint request that was already requested.
>
> CS
> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
> specified FramePop event was already requested. This makes it consistent with
> the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to
> add a breakpoint request that was already requested.
>
> CS
> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
> stepping in some cases.
> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
> `JVMTI_ERROR_DUPLICATE` to make it consistent with the `SetBreakpoint` which
> also returns this error.
>
> The
On Tue, 7 Jan 2025 02:36:36 GMT, Coleen Phillimore wrote:
>> Please review this change that makes AccessFlags and modifier_flags u2 types
>> and removes the last remnants of Hotspot adding internal access flags. This
>> change moves AccessFlags and modifier_flags in Klass to alignment gaps
>>
> There are a lot of format modifiers that are noisy and unnecessary in the
> code. This change removes the INTX variants. It's not that disruptive even
> for backporting because %z modifier has been available for a long time so
> should backport fine. This was mostly done with a sed script p
On Tue, 7 Jan 2025 08:48:08 GMT, Kim Barrett wrote:
>> I don't think we should be mixing uintx types and UINTPTR_FORMAT like that.
>> As I said earlier, this is one that
>> I think probably ought not be changed at all. I think some of the FORMAT
>> macros are useful to avoid inline
>> format
On Tue, 7 Jan 2025 08:50:04 GMT, Kim Barrett wrote:
>> I'd forgotten about that format option too, which is why I'm not enamored of
>> it. Also, written that way the
>> prefix gets included in the width when dealing with field width, which might
>> not be great either.
>
> The problem of accou
Hi Kevin, all,
If there is any resistance or reason not to do this in the JDK, then I guess
it's something that does not absolutely have to be in the JDK itself. A
proxy-like tool that is outside the JDK can work.
I believe we have an use case what I shown at least even though it might not
On Tue, 7 Jan 2025 08:31:13 GMT, Kim Barrett wrote:
>> I fixed this. This seems ok. I didn't know about this format option tbh
>> but if it's standard, why not?
>
> I'd forgotten about that format option too, which is why I'm not enamored of
> it. Also, written that way the
> prefix gets inc
On Tue, 7 Jan 2025 08:28:32 GMT, Kim Barrett wrote:
>> @theRealAph added this with the secondary super cache work, but I think it
>> may have also been meant to be zx because of the leading 0x. So
>> INTPTR_FORMAT would also work.
>
> I don't think we should be mixing uintx types and UINTPTR_F
On Mon, 6 Jan 2025 15:04:19 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/gc/shared/ageTable.cpp line 38:
>>
>>> 36: #include "logging/logStream.hpp"
>>> 37:
>>> 38: /* Copyright (c) 1992, 2025, Oracle and/or its affiliates, and Stanford
>>> University.
>>
>> Well this is weird. An atyp
On Mon, 6 Jan 2025 15:21:14 GMT, Coleen Phillimore wrote:
>> I have to confess that I have no idea what this is trying to show. I'd
>> rather have all the UINTX_FORMAT purged and not leave a remnant for these
>> two special cases. A function whose name describes what this is trying to
>> sho
Trivial logging message change.
-
Commit messages:
- trivial logging change
Changes: https://git.openjdk.org/jdk/pull/22939/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22939&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8347083
Stats: 6 lines in 3 files change
On Tue, 7 Jan 2025 07:58:18 GMT, Ramkumar Sunderbabu
wrote:
> Trivial logging message change.
Sanity testing done.
-
PR Comment: https://git.openjdk.org/jdk/pull/22939#issuecomment-2574615336
31 matches
Mail list logo
