Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-22 Thread Alan Bateman
On Wed, 22 May 2024 21:42:14 GMT, Kevin Rushforth wrote: > Further, I confirm that if I pass that option to jlink or jpackage when > creating a custom runtime, there is no warning. Great! What about jpackage without a custom runtime, wondering if --java-options can be tested. - P

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-22 Thread Kevin Rushforth
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v3]

2024-05-22 Thread Larry Cable
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with two > additional commits since the last revision: > > - Remo

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v3]

2024-05-22 Thread Sebastian Lövdahl
On Wed, 22 May 2024 18:40:00 GMT, Larry Cable wrote: > I haven't but I will BTW which linux capabilities should be enabled in order > to prevent a /proc/... style attach due to lack of permissions to access > target's /proc fs? Rgds - Larry I know for sure that `CAP_NET_BIND_SERVICE` prevents

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v3]

2024-05-22 Thread Larry Cable
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with two > additional commits since the last revision: > > - Remo

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v7]

2024-05-22 Thread Chris Plummer
On Wed, 22 May 2024 17:43:53 GMT, Chris Plummer wrote: >>> Is that "then popFrameEventLock second" >>> >> Yes. I'll fix. >> >>> Drawing these out in two columns I can't see a deadlock either 8-) >> >> Ironically right now I'm looking at a very rare deadlock that involves this >> code. It does

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v7]

2024-05-22 Thread Chris Plummer
On Thu, 16 May 2024 20:02:22 GMT, Chris Plummer wrote: > Ironically right now I'm looking at a very rare deadlock that involves this > code. It doesn't seem to happen when I disabled ranked locking. It might be > instigated by the dbgRawMonitor that ranked locking uses. @kevinjwalls I tracked

Re: RFR: 8332641: Update nsk.share.jpda.Jdb to don't use finalization

2024-05-22 Thread Chris Plummer
On Tue, 21 May 2024 21:49:51 GMT, Leonid Mesnik wrote: > The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and > output streams. > > The fix renames the method to close() and calls it explicitly after the test > finishes. I verified that close() called for each nsk share j

Re: RFR: 8332631: Update nsk.share.jpda.BindServer to don't use finalization

2024-05-22 Thread Chris Plummer
On Tue, 21 May 2024 19:55:01 GMT, Leonid Mesnik wrote: > The BindServer starts several threads and opens streams. > > It registered them for cleanup using "Finalizer" from nsk.share.framework. > Currently, it cleanup resources during shutdown hook. > > This fix changes BindServer to explicitly

Integrated: 8332071: Convert package.html files in `java.management.rmi` to package-info.java

2024-05-22 Thread Nizar Benalla
On Thu, 16 May 2024 10:39:43 GMT, Nizar Benalla wrote: > Please review this change. I converted the `package.html` file to > `package-info.java`, because `javac` cannot recognize `package.html`. > I already brought this up [in the mailing > list](https://mail.openjdk.org/pipermail/serviceabilit

Re: RFR: 8332071: Convert package.html files in `java.management.rmi` to package-info.java [v5]

2024-05-22 Thread Roger Riggs
On Mon, 20 May 2024 20:55:16 GMT, Nizar Benalla wrote: >> Please review this change. I converted the `package.html` file to >> `package-info.java`, because `javac` cannot recognize `package.html`. >> I already brought this up [in the mailing >> list](https://mail.openjdk.org/pipermail/serviceab

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v3]

2024-05-22 Thread Sebastian Lövdahl
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with two > additional commits since the last revision: > > - Remo

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v3]

2024-05-22 Thread Sebastian Lövdahl
On Tue, 21 May 2024 21:06:22 GMT, Larry Cable wrote: >> Sebastian Lövdahl has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove unused `SELF_PID_NS` >> - Rewrite in line with suggestion from Larry Cable > > Hi Sebastian! > > On 5/21

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v8]

2024-05-22 Thread Magnus Ihse Bursie
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa