Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v4]

2024-03-26 Thread Serguei Spitsyn
> This PR fixes a synchronization issue in the test: > `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest` > > The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it > has not reached an expected breakpoint yet. > The fix is to add a call to the method `ensureAt

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-26 Thread Chris Plummer
On Tue, 26 Mar 2024 21:55:38 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is no

Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v3]

2024-03-26 Thread Chris Plummer
On Wed, 27 Mar 2024 02:57:40 GMT, Serguei Spitsyn wrote: >> This PR fixes a synchronization issue in the test: >> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest` >> >> The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it >> has not reached an expected br

Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v3]

2024-03-26 Thread Serguei Spitsyn
> This PR fixes a synchronization issue in the test: > `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest` > > The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it > has not reached an expected breakpoint yet. > The fix is to add a call to the method `ensureAt

Integrated: JDK-8315575: Retransform of record class with record component annotation fails with CFE

2024-03-26 Thread Alex Menkov
On Fri, 8 Mar 2024 02:54:49 GMT, Alex Menkov wrote: > RecordComponent class has _attributes_count field. > The only user of the field is JvmtiClassFileReconstituter. Incorrect value of > the field causes producing incorrect data for Record attribute. > Parsing Record attribute ClassFileParser sk

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-26 Thread Serguei Spitsyn
On Tue, 26 Mar 2024 21:55:38 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is no

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-26 Thread Serguei Spitsyn
On Tue, 26 Mar 2024 21:55:38 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is no

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v8]

2024-03-26 Thread Kevin Walls
On Tue, 26 Mar 2024 20:52:30 GMT, Serguei Spitsyn wrote: >> Kevin Walls has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 20 additional >> commits

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-26 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose customer-facing tool. Kevin Walls ha

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v9]

2024-03-26 Thread Chris Plummer
On Tue, 26 Mar 2024 13:57:55 GMT, Matthias Baesken wrote: >> Currently jcmd command GC.heap_dump only works with an additionally provided >> file name. >> Syntax : GC.heap_dump [options] >> >> In case the JVM has the XX - flag HeapDumpPath set, we should support an >> additional mode where th

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v8]

2024-03-26 Thread Serguei Spitsyn
On Tue, 26 Mar 2024 17:01:49 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is no

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v8]

2024-03-26 Thread Serguei Spitsyn
On Tue, 26 Mar 2024 17:01:49 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is no

Re: RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE [v7]

2024-03-26 Thread Alex Menkov
On Tue, 26 Mar 2024 19:10:11 GMT, Coleen Phillimore wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added comment > > test/jdk/java/lang/instrument/RetransformRecordAnnotation.java line 30: > >> 28: * >> 29: * @l

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v15]

2024-03-26 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Merge - Missing co

Re: RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE [v3]

2024-03-26 Thread Coleen Phillimore
On Thu, 14 Mar 2024 22:09:55 GMT, Alex Menkov wrote: >> It does not matter what the `ClassFileParser` does. >> >>> ` JvmtiClassFileReconstituter` performs the reverse operation. >> >> True. It should know how to put the `attribute_count` value into the class >> file but it does not need to kno

Re: RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE [v7]

2024-03-26 Thread Coleen Phillimore
On Thu, 21 Mar 2024 18:10:49 GMT, Alex Menkov wrote: >> RecordComponent class has _attributes_count field. >> The only user of the field is JvmtiClassFileReconstituter. Incorrect value >> of the field causes producing incorrect data for Record attribute. >> Parsing Record attribute ClassFilePars

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v4]

2024-03-26 Thread Bill Huang
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary direc

Re: RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE [v7]

2024-03-26 Thread Alex Menkov
On Thu, 21 Mar 2024 18:10:49 GMT, Alex Menkov wrote: >> RecordComponent class has _attributes_count field. >> The only user of the field is JvmtiClassFileReconstituter. Incorrect value >> of the field causes producing incorrect data for Record attribute. >> Parsing Record attribute ClassFilePars

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v8]

2024-03-26 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose customer-facing tool. Kevin Walls ha

Integrated: JDK-8328930: [AIX] remove pase related coding

2024-03-26 Thread Matthias Baesken
On Mon, 25 Mar 2024 13:26:12 GMT, Matthias Baesken wrote: > We still have quite a lot of OS400 / pase related coding in the hotspot AIX > codebase. But this does not work and was never supported in OpenJDK. So we > can remove this. This pull request has now been integrated. Changeset: 153410f

Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Matthias Baesken
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken wrote: >> We still have quite a lot of OS400 / pase related coding in the hotspot AIX >> codebase. But this does not work and was never supported in OpenJDK. So we >> can remove this. > > Matthias Baesken has updated the pull request incrementa

Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Lutz Schmidt
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken wrote: >> We still have quite a lot of OS400 / pase related coding in the hotspot AIX >> codebase. But this does not work and was never supported in OpenJDK. So we >> can remove this. > > Matthias Baesken has updated the pull request incrementa

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Michael McMahon
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >> accumu

Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Christoph Langer
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken wrote: >> We still have quite a lot of OS400 / pase related coding in the hotspot AIX >> codebase. But this does not work and was never supported in OpenJDK. So we >> can remove this. > > Matthias Baesken has updated the pull request incrementa

Re: RFR: JDK-8328930: [AIX] remove pase related coding

2024-03-26 Thread Matthias Baesken
On Mon, 25 Mar 2024 13:26:12 GMT, Matthias Baesken wrote: > We still have quite a lot of OS400 / pase related coding in the hotspot AIX > codebase. But this does not work and was never supported in OpenJDK. So we > can remove this. Hi Christoph, I adjusted/removed the comments. -

Re: RFR: JDK-8328930: [AIX] remove pase related coding [v2]

2024-03-26 Thread Matthias Baesken
> We still have quite a lot of OS400 / pase related coding in the hotspot AIX > codebase. But this does not work and was never supported in OpenJDK. So we > can remove this. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: adjust

Re: RFR: JDK-8328930: [AIX] remove pase related coding

2024-03-26 Thread Matthias Baesken
On Tue, 26 Mar 2024 09:27:01 GMT, Christoph Langer wrote: >> We still have quite a lot of OS400 / pase related coding in the hotspot AIX >> codebase. But this does not work and was never supported in OpenJDK. So we >> can remove this. > > src/hotspot/os/aix/os_aix.cpp line 626: > >> 624: >> 6

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v9]

2024-03-26 Thread Matthias Baesken
> Currently jcmd command GC.heap_dump only works with an additionally provided > file name. > Syntax : GC.heap_dump [options] > > In case the JVM has the XX - flag HeapDumpPath set, we should support an > additional mode where the is optional. > In case the filename is NOT set, we take the Hea

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v8]

2024-03-26 Thread Matthias Baesken
On Fri, 15 Mar 2024 11:24:53 GMT, Matthias Baesken wrote: >> Currently jcmd command GC.heap_dump only works with an additionally provided >> file name. >> Syntax : GC.heap_dump [options] >> >> In case the JVM has the XX - flag HeapDumpPath set, we should support an >> additional mode where th

Re: RFR: JDK-8328930: [AIX] remove pase related coding

2024-03-26 Thread Christoph Langer
On Mon, 25 Mar 2024 13:26:12 GMT, Matthias Baesken wrote: > We still have quite a lot of OS400 / pase related coding in the hotspot AIX > codebase. But this does not work and was never supported in OpenJDK. So we > can remove this. Welcome cleanup. I made two minor comments. src/hotspot/os/ai

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Andrey Turbanov
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >> accumu