On Tue, 26 Mar 2024 21:55:38 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
>> information.
>>
>> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
>> and not included in jcmd help output, to remind us this is not a
>> general-purpose customer-facing tool.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Undo include
test/hotspot/jtreg/serviceability/dcmd/vm/VMInspectTest.java line 123:
> 121: ptr = findPointer(threadPrintOutput, waiting_on_mylock, 1);
> 122: output = executor.execute("VM.inspect " + pointerText(ptr));
> 123: System.out.println(output);
Nit: May I ask you to add empty lines after the lines 101 and 123 to make the
code more readable?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1540205562
