On Wed, 14 Feb 2024 12:16:38 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/runtime/threads.cpp line 1200:
>>
>>> 1198: if (pending == monitor ||
>>> 1199: (waiting == monitor &&
>>> JavaThreadStatus::BLOCKED_ON_MONITOR_ENTER ==
>>> 1200: java_lang_Thread::get_thread_stat
On Mon, 12 Feb 2024 18:04:21 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Thu, 1 Feb 2024 10:31:14 GMT, Thomas Stuefe wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spelling
>
> I'm busy with FOSDEM this week and probably next. Will look at this end of
> next week or the week afte
On Thu, 15 Feb 2024 02:45:26 GMT, Alex Menkov wrote:
>> The fix updates heap dumpers to report correct instance size value for
>> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
>> fields)
>>
>> Testing: tier1, tier2, tier5-svc
>
> Alex Menkov has updated the pull
On Tue, 13 Feb 2024 10:29:48 GMT, Magnus Ihse Bursie wrote:
>> src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleWriter.cpp line
>> 202:
>>
>>> 200: static RootDescriptionInfo* root_infos = nullptr;
>>> 201:
>>> 202: static int __write_sample_info__(JfrCheckpointWriter* writer, const
> The fix updates heap dumpers to report correct instance size value for
> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
> fields)
>
> Testing: tier1, tier2, tier5-svc
Alex Menkov has updated the pull request incrementally with one additional
commit since the las
The fix updates heap dumpers to report correct instance size value for
HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
fields)
Testing: tier1, tier2, tier5-svc
-
Commit messages:
- jcheck
- fix
Changes: https://git.openjdk.org/jdk/pull/17855/files
W
On Wed, 14 Feb 2024 15:25:33 GMT, Serguei Spitsyn wrote:
>> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
>> spec.
>> The function returns the following structure:
>>
>>
>> typedef struct {
>> jthread owner;
>> jint entry_count;
>> jint waiter_count;
>
On Wed, 14 Feb 2024 20:17:21 GMT, Albert Mingkun Yang wrote:
>> Relocate `Generation.java` to mirror the structure in hotspot. Also,
>> specialize the logic to two concrete generations.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with three
> addition
On Wed, 14 Feb 2024 18:33:19 GMT, Daniel D. Daugherty
wrote:
>>> When you get the chance, can you checkout these possible
>> changes for the objmonusage001 test?
>>
>> Thanks, Dan. I've pushed the suggested test changes but refactored them a
>> little bit.
>
>> Thanks, Dan. I've pushed the sug
> Relocate `Generation.java` to mirror the structure in hotspot. Also,
> specialize the logic to two concrete generations.
>
> Test: tier1-3
Albert Mingkun Yang has updated the pull request incrementally with three
additional commits since the last revision:
- remove-space-ite
- remove
- ye
On Wed, 14 Feb 2024 19:57:00 GMT, Chris Plummer wrote:
>> Albert Mingkun Yang has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains one commit:
>>
>> sa-move-generation
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared
On Wed, 14 Feb 2024 17:39:13 GMT, Albert Mingkun Yang wrote:
>> Relocate `Generation.java` to mirror the structure in hotspot. Also,
>> specialize the logic to two concrete generations.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request with a new target base due
> to a m
On Fri, 1 Dec 2023 07:56:04 GMT, Emanuel Peter wrote:
> Before this patch, we always initialized the GrowableArray up to its
> `capacity`, and not just up to `length`. This is problematic for a few
> reasons:
>
> - It is not expected. `std::vector` also only initializes the elements up to
> i
On Thu, 14 Dec 2023 10:13:51 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to improve the code
> in `get_user_name_slow` function, which is used to identify the target JVM
> owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971.
>
>
On Wed, 14 Feb 2024 11:56:27 GMT, Serguei Spitsyn wrote:
> Thanks, Dan. I've pushed the suggested test changes but refactored them a
> little bit.
You are welcome. I presume the revised test passes with your fix in place. I
made the
test changes on a baseline repo and not a repo that had your
> Relocate `Generation.java` to mirror the structure in hotspot. Also,
> specialize the logic to two concrete generations.
>
> Test: tier1-3
Albert Mingkun Yang has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
On Mon, 12 Feb 2024 12:43:09 GMT, Magnus Ihse Bursie wrote:
> There are several places in hotspot where an internal function should have
> been declared static, but isn't.
>
> These were discovered by trying to use the gcc option
> `-Wmissing-declarations` and the corresponding clang option
On Tue, 13 Feb 2024 11:05:30 GMT, Magnus Ihse Bursie wrote:
>> There are several places in hotspot where an internal function should have
>> been declared static, but isn't.
>>
>> These were discovered by trying to use the gcc option
>> `-Wmissing-declarations` and the corresponding clang opt
On Thu, 8 Feb 2024 07:05:38 GMT, David Holmes wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> comm
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
> jthread
On Thu, 8 Feb 2024 13:46:40 GMT, Markus Grönlund wrote:
> Greetings,
>
> The following adjustments fix the intermittent issues with incomplete tag
> sets for a chunk. The situations are pretty subtle:
>
> 1. A situation can occur where an event is emitted during the event
> instrumentation ca
On Fri, 9 Feb 2024 15:51:32 GMT, Erik Gahlin wrote:
>> Greetings,
>>
>> The following adjustments fix the intermittent issues with incomplete tag
>> sets for a chunk. The situations are pretty subtle:
>>
>> 1. A situation can occur where an event is emitted during the event
>> instrumentation
Relocate `Generation.java` to mirror the structure in hotspot. Also, specialize
the logic to two concrete generations.
Test: tier1-3
-
Commit messages:
- sa-move-generation
Changes: https://git.openjdk.org/jdk/pull/17844/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1784
On Wed, 14 Feb 2024 02:18:58 GMT, David Holmes wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> comm
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
> jthread
On Tue, 13 Feb 2024 22:30:56 GMT, Daniel D. Daugherty
wrote:
> When you get the chance, can you checkout these possible
changes for the objmonusage001 test?
Thanks, Dan. I've pushed the suggested test changes but refactored them a
little bit.
-
PR Comment: https://git.openjdk.org
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
> jthread
On Tue, 13 Feb 2024 11:05:30 GMT, Magnus Ihse Bursie wrote:
>> There are several places in hotspot where an internal function should have
>> been declared static, but isn't.
>>
>> These were discovered by trying to use the gcc option
>> `-Wmissing-declarations` and the corresponding clang opt
On Mon, 12 Feb 2024 16:47:59 GMT, Stefan Karlsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert spurious changes in non-modified file
>> - Fix indentation issues
>
> The argument alignment is wonk
30 matches
Mail list logo
