On Thu, 15 Feb 2024 02:45:26 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The fix updates heap dumpers to report correct instance size value for >> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance >> fields) >> >> Testing: tier1, tier2, tier5-svc > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > test bug id The test is odd in a couple of ways. The first is it's in the SA test directory, yet is also meant as a VM heap dump test. If someone were to make changes to the VM heapdump code and run the VM heapdump tests, this test would not get run. The other oddity is that it is not testing if the hprof file is correct. It is instead testing if SA and the VM produce the same result. Although that is a valid thing to test for, it seems correctness should also be tested for. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17855#issuecomment-1945328399
