On Wed, 14 Feb 2024 17:39:13 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:

>> Relocate `Generation.java` to mirror the structure in hotspot. Also, 
>> specialize the logic to two concrete generations.
>> 
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request with a new target base due 
> to a merge or a rebase. The pull request now contains one commit:
> 
>   sa-move-generation

TestUniverse.java needs a copyright update.

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Generation.java 
line 112:

> 110:   public boolean isIn(Address p) {
> 111:     GenerationIsInClosure blk = new GenerationIsInClosure(p);
> 112:     spaceIterate(blk);

It looks like spaceIterate() is no longer needed.

-------------

Changes requested by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17844#pullrequestreview-1881158055
PR Review Comment: https://git.openjdk.org/jdk/pull/17844#discussion_r1489990254

Reply via email to