On Thu, 4 Jan 2024 02:00:24 GMT, Chris Plummer wrote:
> Use "cause" argument when rethrowing an exception. See CR for details on how
> this helps.
>
> Tested with all of tier1, and also ran tier2 and tier4 svc tests.
>
> I'd like to push this as a trivial change.
Marked as reviewed by lmesnik
On Fri, 5 Jan 2024 02:24:44 GMT, Denghui Dong wrote:
>>> It means that either Serial is set (and available) or it can be set
>>
>> @stefank that is subtle - and unintuitive. Thanks for explaining.
>
> @dholmes-ora Thanks for the review.
>
> This change only involves the test part. Do I need a
On Thu, 4 Jan 2024 20:37:39 GMT, David Holmes wrote:
>>> > For this test I think we can just add @requires vm.gc.Serial
>>>
>>> @stefank but it doesn't require that, it explicitly sets that. The test
>>> requires that no specific GC has been requested.
>>
>> @dholmes-ora `@requires vm.gc.Seria
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update copyright
-
Change
On Fri, 5 Jan 2024 00:47:48 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request with a new target base due to a
> merge or a
On Fri, 5 Jan 2024 00:47:48 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request with a new target base due to a
> merge or a
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes bro
On Thu, 4 Jan 2024 02:00:24 GMT, Chris Plummer wrote:
> Use "cause" argument when rethrowing an exception. See CR for details on how
> this helps.
>
> Tested with all of tier1, and also ran tier2 and tier4 svc tests.
>
> I'd like to push this as a trivial change.
Okay - thanks. Change is triv
On Thu, 4 Jan 2024 15:54:50 GMT, Stefan Karlsson wrote:
> It means that either Serial is set (and available) or it can be set
@stefank that is subtle - and unintuitive. Thanks for explaining.
-
PR Comment: https://git.openjdk.org/jdk/pull/17263#issuecomment-1877728970
On Thu, 4 Jan 2024 02:18:10 GMT, Chris Plummer wrote:
> Remove unused debugMonitorTimedWait() function.
>
> Tested with all of tier1, and also ran tier2 and tier4 svc tests.
>
> I'd like to push this as a trivial change.
Thanks for the reviews David and Serguei.
-
PR Comment: htt
On Thu, 4 Jan 2024 02:18:10 GMT, Chris Plummer wrote:
> Remove unused debugMonitorTimedWait() function.
>
> Tested with all of tier1, and also ran tier2 and tier4 svc tests.
>
> I'd like to push this as a trivial change.
This pull request has now been integrated.
Changeset: 3fbccb01
Author:
On Thu, 4 Jan 2024 17:00:20 GMT, Kevin Walls wrote:
> A future idea could be to have these ifdefs active in the debug JDK build. I
> wouldn't normally run the debugger from the debug build, but if you wanted
> this extra info it would be more convenient if it was in the debug JDK bundle.
Possi
On Thu, 4 Jan 2024 06:56:37 GMT, David Holmes wrote:
> Setting the cause is good, but do you not also want an informative message?
Not necessary.
public class Test {
public static void main(String[] args) {
try {
try {
throw new Throwable("hello");
On Thu, 4 Jan 2024 02:06:28 GMT, Chris Plummer wrote:
> In threadControl.c, at build time you can decide to keep track of thread
> names by compiling with "#define DEBUG_THREADNAME". If this is also a debug
> build, some extra debugging functions are included in the build, including
> "dumpThr
On Thu, 4 Jan 2024 15:37:33 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
A trivial fix to ProblemList
serviceability/HeapDump/FullGCHeapDumpLimitTest.java
on all platforms.
We're already up to 54 failures in Tier3 and Tier5.
-
Commit messages:
- 8323011: ProblemList serviceability/HeapDump/FullGCHeapDumpLimitTest.java
Changes: https://git.openjdk.org/
On Thu, 4 Jan 2024 16:24:53 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> serviceability/HeapDump/FullGCHeapDumpLimitTest.java
> on all platforms.
>
> We're already up to 54 failures in Tier3 and Tier5.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: h
On Thu, 4 Jan 2024 16:27:05 GMT, Alexander Zvegintsev
wrote:
>> A trivial fix to ProblemList
>> serviceability/HeapDump/FullGCHeapDumpLimitTest.java
>> on all platforms.
>>
>> We're already up to 54 failures in Tier3 and Tier5.
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint and @ct
On Thu, 4 Jan 2024 16:24:53 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> serviceability/HeapDump/FullGCHeapDumpLimitTest.java
> on all platforms.
>
> We're already up to 54 failures in Tier3 and Tier5.
This pull request has now been integrated.
Changeset: ea19e9c6
Author:
On Thu, 4 Jan 2024 16:24:53 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> serviceability/HeapDump/FullGCHeapDumpLimitTest.java
> on all platforms.
>
> We're already up to 54 failures in Tier3 and Tier5.
Marked as reviewed by ctornqvi (Reviewer).
-
PR Review: h
On Thu, 4 Jan 2024 16:06:26 GMT, Daniel D. Daugherty wrote:
> We're up to 48 test failures so far (8 x 6 Tier3 buildIDs) which is very,
> very noisy. Since it looks like this PR is still being discussed, I'm going
> to ProblemList this test in order to get the noise level back down.
sorry for
On Thu, 4 Jan 2024 15:37:33 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Please help review this patch that fixes the failures of
>> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>>
>> Thanks.
>
> Denghui Dong has updated the pull request incrementally with one additional
> commit s
On Thu, 4 Jan 2024 11:56:45 GMT, David Holmes wrote:
> > For this test I think we can just add @requires vm.gc.Serial
>
> @stefank but it doesn't require that, it explicitly sets that. The test
> requires that no specific GC has been requested.
@dholmes-ora `@requires vm.gc.Serial` doesn't mea
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
Denghui Dong has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong wrote:
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
And for this test, I think `@requires vm.opt.DisableExplicitGC != "true"` is
also needed.
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong wrote:
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
I found other tests that set -XX:+UseSerialGC explicitly have `@requires
vm.gc.Serial` or `vm.
> Compiler Control (https://openjdk.org/jeps/165) provides method-context
> dependent control of the JVM compilers (C1 and C2). The active directive
> stack is built from the directive files passed with the
> `-XX:CompilerDirectivesFile` diagnostic command-line option and the
> Compiler.add_dir
On Thu, 4 Jan 2024 02:18:10 GMT, Chris Plummer wrote:
> Remove unused debugMonitorTimedWait() function.
>
> Tested with all of tier1, and also ran tier2 and tier4 svc tests.
>
> I'd like to push this as a trivial change.
Looks okay.
-
Marked as reviewed by sspitsyn (Reviewer).
P
On Thu, 4 Jan 2024 10:01:41 GMT, Stefan Karlsson wrote:
> For this test I think we can just add @requires vm.gc.Serial
@stefank but it doesn't require that, it explicitly sets that. The test
requires that no specific GC has been requested.
-
PR Comment: https://git.openjdk.org/jdk
> Remove the MLet feature and its tests.
>
> Some tests use MLet classes but are not testing MLets. These are updated, to
> use another test MBean or an MBean which is a URLClassLoader, e.g.
> test/jdk/javax/management/MBeanServer/PostExceptionTest.java
> test/jdk/javax/management/remote/mandato
> Remove the MLet feature and its tests.
>
> Some tests use MLet classes but are not testing MLets. These are updated, to
> use another test MBean or an MBean which is a URLClassLoader, e.g.
> test/jdk/javax/management/MBeanServer/PostExceptionTest.java
> test/jdk/javax/management/remote/mandato
On Thu, 4 Jan 2024 10:02:39 GMT, Kevin Walls wrote:
>> test/jdk/javax/management/Introspector/ClassLeakTest.java line 53:
>>
>>> 51:
>>> 52: MBeanServer mbs = MBeanServerFactory.createMBeanServer();
>>> 53: ObjectName testName = new ObjectName("x:name=Test");
>>
>> Q: I'd just
On Thu, 4 Jan 2024 02:13:18 GMT, Serguei Spitsyn wrote:
>> Remove the MLet feature and its tests.
>>
>> Some tests use MLet classes but are not testing MLets. These are updated,
>> to use another test MBean or an MBean which is a URLClassLoader, e.g.
>> test/jdk/javax/management/MBeanServer/Po
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong wrote:
> Hi,
>
> Please help review this patch that fixes the failures of
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
I prefer if we stay away from using `@requires vm.flagless` if possible. For
this test I think
On Thu, 4 Jan 2024 02:39:17 GMT, Bernd wrote:
>> Remove the MLet feature and its tests.
>>
>> Some tests use MLet classes but are not testing MLets. These are updated,
>> to use another test MBean or an MBean which is a URLClassLoader, e.g.
>> test/jdk/javax/management/MBeanServer/PostExceptio
On Thu, 4 Jan 2024 01:57:29 GMT, Serguei Spitsyn wrote:
>> Remove the MLet feature and its tests.
>>
>> Some tests use MLet classes but are not testing MLets. These are updated,
>> to use another test MBean or an MBean which is a URLClassLoader, e.g.
>> test/jdk/javax/management/MBeanServer/Po
On Wed, 3 Jan 2024 11:41:20 GMT, Matthias Baesken wrote:
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> th
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
Hi,
Please help review this patch that fixes the failures of
FullGCHeapDumpLimitTest.java caused by passing other gc flags.
Thanks.
-
Commit messages:
- 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
Changes: https://git.openjdk.org/jdk/pull/17263/fi
40 matches
Mail list logo
