On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong <dd...@openjdk.org> wrote:

> Hi,
> 
> Please help review this patch that fixes the failures of 
> FullGCHeapDumpLimitTest.java caused by passing other gc flags.
> 
> Thanks.

I prefer if we stay away from using `@requires vm.flagless` if possible. For 
this test I think we can just add `@requires vm.gc.Serial`? Could you try that 
instead?

-------------

Changes requested by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17263#pullrequestreview-1803844916

Reply via email to