On Thu, 4 Jan 2024 02:39:17 GMT, Bernd <d...@openjdk.org> wrote: >> Remove the MLet feature and its tests. >> >> Some tests use MLet classes but are not testing MLets. These are updated, >> to use another test MBean or an MBean which is a URLClassLoader, e.g. >> test/jdk/javax/management/MBeanServer/PostExceptionTest.java >> test/jdk/javax/management/remote/mandatory/loading/TargetMBeanTest.java > > src/java.management/share/classes/javax/management/loading/MLet.java line 68: > >> 66: import javax.management.ReflectionException; >> 67: >> 68: import static com.sun.jmx.defaults.JmxProperties.MLET_LIB_DIR; > > Do those 2 statics in JmxProperties also need to be removed?
Yes good question - there are a couple of other definitions, they will be removed later if not now. I was hesitant and was thinking maybe they should be removed later. But looking again I find no other references to these, they are not part of the documented interface, so I should update this to remove them now. src/java.management/share/classes/com/sun/jmx/defaults/JmxProperties.java MLET_LIB_DIR only used by MLet.java MLET_LOGGER_NAME used in same file to define MLET_LOGGER MLET_LOGGER used by MLet.java and MLetParser.java JMX_INITIAL_BUILDER defined above MLET_LIB_DIR has an incorrect name in the comment. src/java.management/share/classes/com/sun/jmx/defaults/ServiceName.java public static final String MLET = "type=MLet"; only used by MLet.java ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16363#discussion_r1441521876
