On Thu, 28 Sep 2023 06:11:52 GMT, Varada M wrote:
>> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
>> where AttachCurrentThread is failing on AIX due t stack size issue.
>> Test cases:
>> runtime/jni/terminatedThread/TestTerminatedThread.java
>> vmTestbase/nsk/jvmti/
On Wed, 27 Sep 2023 15:54:15 GMT, Chris Plummer wrote:
>> Any test fixed by this PR should be removed from the problem list by this
>> PR. If there are any tests problem listed with this CR that still fail after
>> it is fixed, then they need to have a new CR filed for them, and the problem
>>
On Thu, 28 Sep 2023 04:30:16 GMT, David Holmes wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added pthread attritubes to libterminatedThread.c
>
> test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp line
> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
> where AttachCurrentThread is failing on AIX due t stack size issue.
> Test cases:
> runtime/jni/terminatedThread/TestTerminatedThread.java
> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Okay looks reasonable then.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: http
On Wed, 27 Sep 2023 08:40:48 GMT, Varada M wrote:
>> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
>> where AttachCurrentThread is failing on AIX due t stack size issue.
>> Test cases:
>> runtime/jni/terminatedThread/TestTerminatedThread.java
>> vmTestbase/nsk/jvmti/
On Wed, 27 Sep 2023 07:25:50 GMT, Alan Bateman wrote:
> > Is there anything to tell you which carrier thread is associated with which
> > mounted VThread?
>
> The carrier and virtual threads are distinct and the HPROF format doesn't
> have record types to support associations like this. Howeve
On Fri, 22 Sep 2023 08:36:10 GMT, Jean-Philippe Bempel
wrote:
> increase Metaspace size and loop count to avoid OOME in nominal case
This pull request has now been integrated.
Changeset: 84390dd0
Author:Jean-Philippe Bempel
Committer: David Holmes
URL:
https://git.openjdk.org/jdk/
On Wed, 27 Sep 2023 21:51:38 GMT, Alex Menkov wrote:
>> test/lib/jdk/test/lib/hprof/model/Root.java line 145:
>>
>>> 143:
>>> 144: public long getReferrerId() {
>>> 145: return refererId;
>>
>> Spelling: `referrerId`
>
> This is existing field in the class.
> There are a number (45
On Wed, 27 Sep 2023 08:48:27 GMT, Afshin Zafari wrote:
>> src/hotspot/share/gc/parallel/mutableNUMASpace.hpp line 1:
>>
>>> 1: /*
>>
>> This seems an unrelated change.
>
> This change came after fixing a merge conflict.
> In `mutableNUMASpace.cpp`, at lines 163, 182, 202 and 586 the `find` func
On Thu, 28 Sep 2023 01:57:59 GMT, David Holmes wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Has the change been tested in the HSDB GUI as requested in the JBS issue?
@dholmes-ora thanks for pointi
The change fixes 2 issues in hprof test library.
The issue were discovered during test development (logging values of dumped
heap objects).
- JavaValueArray.elementSize cannot determine size of the array elements and
throws RuntimeException: invalid array element type
- JavaObject.toString() meth
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Has the change been tested in the HSDB GUI as requested in the JBS issue?
-
PR Comment: https://
On Wed, 27 Sep 2023 23:04:22 GMT, Ashutosh Mehra wrote:
>> Can you add to the CR a copy of the `where` output after this fix? Just a
>> short snippet equivalent to the broken output already in the CR. thanks.
>
> @plummercj for some reason the bot refuses to recognize my committer status
> in j
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
https://wiki.openjdk.org/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername
-
On Wed, 27 Sep 2023 12:19:31 GMT, Coleen Phillimore wrote:
> OopHandles and WeakHandles don't have destructors
Hmmm okay - it seems fragile to have a psuedo-destructor in `release()`.
-
PR Comment: https://git.openjdk.org/jdk/pull/15920#issuecomment-1738324423
On Wed, 27 Sep 2023 17:54:51 GMT, Roman Kennke wrote:
>> The SA can run concurrently with Java threads, SA code that inspects locking
>> state should be able to deal with that. On the other hand, the particular
>> code is only used in printing routine and is not expected to be precise.
>> When
On Wed, 27 Sep 2023 21:07:18 GMT, Chris Plummer wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Can you add to the CR a copy of the `where` output after this fix? Just a
> short snippet equivalent to
On Wed, 27 Sep 2023 21:07:18 GMT, Chris Plummer wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Can you add to the CR a copy of the `where` output after this fix? Just a
> short snippet equivalent to
On Wed, 27 Sep 2023 07:25:50 GMT, Alan Bateman wrote:
> Is there anything to tell you which carrier thread is associated with which
> mounted VThread?
No (at least for now).
I'm not sure if we need this information in heap dump (and if we need a way to
differentiate platform(carrier)/virtual th
On Wed, 27 Sep 2023 20:23:03 GMT, Leonid Mesnik wrote:
> The main.wrapper was the first name for jtreg test thread factory plugin.
> However, during integration of this feature in jtreg it was decided to use
> test.thread.factory name. So this fix just renames "main.wrapper" property to
> "te
On Wed, 27 Sep 2023 07:11:26 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> David's feedback
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/HeapDump/VtreadInHeapDump.java
> line 1:
>
>> 1:
> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
> stack references
> The change:
> - reorganize thread-related code/prepare it to use for unmounted vthreads:
> - new ThreadDumper class caches stack frames, thread serial num, frame
> serial number (trace serial number
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Looks good. Thanks!
-
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjd
> Compiler Control (https://openjdk.org/jeps/165) provides method-context
> dependent control of the JVM compilers (C1 and C2). The active directive
> stack is built from the directive files passed with the
> `-XX:CompilerDirectivesFile` diagnostic command-line option and the
> Compiler.add_dir
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Updated CR with the output of `where` command after the fix.
-
PR Comment: https://git.openjdk.o
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Can you add to the CR a copy of the `where` output after this fix? Just a short
snippet equivalent to the bro
Please review trivial fix to display class name in the output of "where"
command of SA.
Testing: hotspot_serviceability
-
Commit messages:
- 8313631: SA: stack trace printed using "where" command does not show class
name
Changes: https://git.openjdk.org/jdk/pull/15952/files
Webr
The main.wrapper was the first name for jtreg test thread factory plugin.
However, during integration of this feature in jtreg it was decided to use
test.thread.factory name. So this fix just renames "main.wrapper" property to
"test.thread.factory" so it is more compliant with jtreg naming. Als
On Wed, 27 Sep 2023 17:54:51 GMT, Roman Kennke wrote:
>> The SA can run concurrently with Java threads, SA code that inspects locking
>> state should be able to deal with that. On the other hand, the particular
>> code is only used in printing routine and is not expected to be precise.
>> When
> The SA can run concurrently with Java threads, SA code that inspects locking
> state should be able to deal with that. On the other hand, the particular
> code is only used in printing routine and is not expected to be precise. When
> resolving an anonymous owner, we may not find one, because
On Wed, 27 Sep 2023 16:59:17 GMT, Roman Kennke wrote:
>> I think given this, issuing a warning is the appropriate thing to do. The
>> warning might want to mention that the failure is likely because we are in
>> the middle of a GC. That way the user has some context as to why SA info is
>> not
On Wed, 27 Sep 2023 15:42:51 GMT, Chris Plummer wrote:
>> I think you are right @plummercj - I'm adding details to the JBS issue.
>
> I think given this, issuing a warning is the appropriate thing to do. The
> warning might want to mention that the failure is likely because we are in
> the midd
On Wed, 27 Sep 2023 10:36:08 GMT, Kevin Walls wrote:
>> What was the cause of all the 0's in the output, and how did you get rid of
>> them so you could see the assert message?
>
> Thanks Leonid!
>
> On the \u content, I don't see that mess in the console (cygwin) if I
> make these asserts
On Wed, 27 Sep 2023 15:52:47 GMT, Chris Plummer wrote:
>> Is it like we should create separate PR to remove/add tests from ProblemList
>> or can I remove those from ProblemList in this PR itself. One of the test
>> "TestTerminatedThread.java" still fails so it should be under ProblemList
>> it
On Wed, 27 Sep 2023 08:13:21 GMT, Varada M wrote:
>> test/hotspot/jtreg/ProblemList.txt line 155:
>>
>>> 153:
>>> 154: vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java
>>> 8202971 generic-all
>>> 155:
>>> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/TestDesc
On Thu, 14 Sep 2023 17:24:39 GMT, Kevin Walls wrote:
> This assert happens rarely, but is seen in testing a few times.
>
> getCurrentQueryIndexForProcess comments that it can return -1, but it asserts
> that the value is >=0
>
> If we let it return -1 for failure as its comment documents, the
On Thu, 14 Sep 2023 17:24:39 GMT, Kevin Walls wrote:
> This assert happens rarely, but is seen in testing a few times.
>
> getCurrentQueryIndexForProcess comments that it can return -1, but it asserts
> that the value is >=0
>
> If we let it return -1 for failure as its comment documents, the
On Wed, 27 Sep 2023 04:17:57 GMT, David Holmes wrote:
>> I wonder if we are in the middle of a GC, the object has been moved, and the
>> lock stack object reference has been updated but the monitor reference has
>> not (or vice versa).
>
> I think you are right @plummercj - I'm adding details t
On Tue, 19 Sep 2023 09:00:01 GMT, Fredrik Bredberg
wrote:
> Relativize initial_sp in interpreter frames.
>
> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
> PowerPC) member in interpreter frames from being an absolute address into an
> offset that is relative to the f
On Wed, 27 Sep 2023 09:07:23 GMT, Fredrik Bredberg
wrote:
>> Relativize initial_sp in interpreter frames.
>>
>> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
>> PowerPC) member in interpreter frames from being an absolute address into an
>> offset that is relative to
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
On Tue, 26 Sep 2023 19:28:47 GMT, Chris Plummer wrote:
>> Fine then. Thank you for the explanation.
>
> What was the cause of all the 0's in the output, and how did you get rid of
> them so you could see the assert message?
Thanks Leonid!
On the \u content, I don't see that mess in the con
On Wed, 27 Sep 2023 09:07:23 GMT, Fredrik Bredberg
wrote:
>> Relativize initial_sp in interpreter frames.
>>
>> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
>> PowerPC) member in interpreter frames from being an absolute address into an
>> offset that is relative to
> Relativize initial_sp in interpreter frames.
>
> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on
> PowerPC) member in interpreter frames from being an absolute address into an
> offset that is relative to the frame pointer, we don't need to change the
> value as we free
On Tue, 26 Sep 2023 21:05:22 GMT, David Holmes wrote:
>> Afshin Zafari has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into _8314502
>> - changed the `E` param of find methods to `cons
> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
> where AttachCurrentThread is failing on AIX due t stack size issue.
> Test cases:
> runtime/jni/terminatedThread/TestTerminatedThread.java
> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.
> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
> where AttachCurrentThread is failing on AIX due t stack size issue.
> Test cases:
> runtime/jni/terminatedThread/TestTerminatedThread.java
> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.
On Thu, 21 Sep 2023 12:02:24 GMT, Afshin Zafari wrote:
> 1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it also
> are removed.
> 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`.
> 3. The signature of `CHeapBitMap::free(ptr, size)` is kept as it
On Tue, 26 Sep 2023 21:08:36 GMT, Coleen Phillimore wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> MetaspaceSize and its lower bound is used.
>
> This looks good to me.
Thank you @coleenp and @dholmes-ora for yo
On Thu, 21 Sep 2023 06:21:25 GMT, Axel Boldt-Christmas
wrote:
>> ObjectMonitorIterator fails to return the most resent monitor added. It
>> start with returning the `nextOM()` ObjectMonitor from the `_head`
>> ObjectMonitor but fails to ever return the `_head` ObjectMonitor.
>> The current imp
On Mon, 18 Sep 2023 09:54:18 GMT, Axel Boldt-Christmas
wrote:
> ObjectMonitorIterator fails to return the most resent monitor added. It start
> with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor
> but fails to ever return the `_head` ObjectMonitor.
> The current impleme
On Tue, 26 Sep 2023 22:38:21 GMT, David Holmes wrote:
> You should be changing the thread creation logic in
> ./nsk/share/native/native_thread.cpp for the nsk test changes.
>
> Thanks
Thank you @dholmes-ora .I have applied changes there. Please review the code
change
-
PR Commen
On Tue, 26 Sep 2023 15:48:01 GMT, Chris Plummer wrote:
>> Varada M has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - AttachCurrentThread() failure solution
>> - Revert "AttachCurrentThread() failure solution"
>>
>>This reverts c
> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
> where AttachCurrentThread is failing on AIX due t stack size issue.
> Test cases:
> runtime/jni/terminatedThread/TestTerminatedThread.java
> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.
On Wed, 27 Sep 2023 07:18:27 GMT, David Holmes wrote:
> Is there anything to tell you which carrier thread is associated with which
> mounted VThread?
The carrier and virtual threads are distinct and the HPROF format doesn't have
record types to support associations like this. However, your qu
On Thu, 21 Sep 2023 20:06:13 GMT, Alex Menkov wrote:
> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
> stack references
> The change:
> - reorganize thread-related code/prepare it to use for unmounted vthreads:
> - new ThreadDumper class caches stack frames, thread
On Thu, 21 Sep 2023 20:06:13 GMT, Alex Menkov wrote:
> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
> stack references
> The change:
> - reorganize thread-related code/prepare it to use for unmounted vthreads:
> - new ThreadDumper class caches stack frames, thread
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
60 matches
Mail list logo
