On Wed, 27 Sep 2023 15:52:47 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Is it like we should create separate PR to remove/add tests from ProblemList >> or can I remove those from ProblemList in this PR itself. One of the test >> "TestTerminatedThread.java" still fails so it should be under ProblemList >> itself. >> >> Thank you > > Any test fixed by this PR should be removed from the problem list by this PR. > If there are any tests problem listed with this CR that still fail after it > is fixed, then they need to have a new CR filed for them, and the problem > list updated to reference the new CR. That problem list updating can also be > done in this PR. ...or you could file a new CR to fix just the tests that this PR is fixing (and update this PR to reference that CR). Then you would only need to remove problem list entries and not update any existing ones. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15924#discussion_r1338830501
