Re: RFR: 8313785: Fix -Wconversion warnings in prims code [v2]

2023-08-07 Thread Dean Long
On Fri, 4 Aug 2023 23:24:45 GMT, Coleen Phillimore wrote: > Why not? It's the same and casts the int where it's needed to be an int. To me the checked_cast looks less ugly in the initialization vs at the uses sites, but in this case with only one use it doesn't really matter. - PR

Re: RFR: 8313854: Some tests in serviceability area fail on localized Windows platform

2023-08-07 Thread Chris Plummer
On Mon, 7 Aug 2023 02:37:15 GMT, Kimura Yukihiro wrote: > I would like to fix this issue > because the svc jtreg test does not pass on localized Windows platform. > Testing: > all serviceability area tests (jdk_svc group). > > Could anyone review the fix please? > > Thanks, > Kimura Yukihiro

RFR: 8313798: [aarch64] sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java sometimes times out on aarch64

2023-08-07 Thread Chris Plummer
Make sure when walking the stack that the "sender" frame is not at a lower or the same address as the current frame, which can result in an infinite loop. Tested with tier1 and stress testing sun/tools/jhsdb and hotspot/jtreg/serviceability/sa tests. - Commit messages: - Detect ba

Integrated: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM

2023-08-07 Thread Chris Plummer
On Fri, 4 Aug 2023 22:41:43 GMT, Chris Plummer wrote: > Normally we want the test args passed to the SA debuggee. In fact for proper > SA test coverage, it is more important for the test args to be passed to the > debuggee than to be passed to the test or the the SA tool that the test > launch

Re: RFR: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM

2023-08-07 Thread Chris Plummer
On Fri, 4 Aug 2023 22:41:43 GMT, Chris Plummer wrote: > Normally we want the test args passed to the SA debuggee. In fact for proper > SA test coverage, it is more important for the test args to be passed to the > debuggee than to be passed to the test or the the SA tool that the test > launch

Integrated: 8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe"

2023-08-07 Thread Alex Menkov
On Wed, 14 Jun 2023 01:02:09 GMT, Alex Menkov wrote: > If virtual thread has frames in stackChunks, need to apply load barriers > before processing nmethods (javaVFrame::locals() and > javaVFrame::expressions() do it internally) > > Testing: tier1-tier5; > 400 runs of VThreadStackRefTest.java

Re: RFR: 8313785: Fix -Wconversion warnings in prims code [v2]

2023-08-07 Thread Coleen Phillimore
On Sat, 5 Aug 2023 16:21:57 GMT, Coleen Phillimore wrote: >> This patch fixes Wconversion in code in the src/hotspot/share/prims >> directory. Most of the changes correct the types. jfieldID's are created >> with the int offset returned by InstanceKlass::field_offset(). >> int field_