On Fri, 4 Aug 2023 22:41:43 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> Normally we want the test args passed to the SA debuggee. In fact for proper > SA test coverage, it is more important for the test args to be passed to the > debuggee than to be passed to the test or the the SA tool that the test > launches. For a couple of jhsdb tests that launch jshell as the debuggee, > this wasn't happening, and jshell was always launched with no extra args. > > Fixing this was very simple. Dealing with the unexpected fallout wasn't. I > filed a number of bugs that turned up (or where otherwise exposed) once I > fixed this CR. The main ones were: > > [JDK-8313798](https://bugs.openjdk.org/browse/JDK-8313798) [aarch64] > sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java sometimes times out on > aarch64 > [JDK-8313655](https://bugs.openjdk.org/browse/JDK-8313655) > sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java frequently fails with > SerialGC > > For the first one I'm problem listing the test for now, but have a fix and > will get it out for review shortly. For the second one I'm just having the > test avoid the issue by not allowing jshell to be launched with SerialGC. > > Note also that this change caused some failures with ZGC due to an already > filed CR. This pull request has now been integrated. Changeset: 87b08b6e Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/87b08b6e0192d88025c2275c7dd2c4bdecda58e8 Stats: 17 lines in 4 files changed: 13 ins; 0 del; 4 mod 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM Reviewed-by: sspitsyn, lmesnik ------------- PR: https://git.openjdk.org/jdk/pull/15168
