Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Alan Bateman
On Thu, 8 Jun 2023 04:41:10 GMT, Serguei Spitsyn wrote: >> Thanks for clarifying - it gets very confusing as to which "thread" is being >> talked about. But if a virtual thread is mounted on this JavaThread then I >> thought the carrier thread's thread-oop is supposed to be in a blocked state?

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
On Thu, 8 Jun 2023 04:29:47 GMT, David Holmes wrote: >>> > A thread carrying a virtual thread can not be in native, blocked, parked, >>> > sleeping or waiting on some object. >> >>>A virtual thread can call native code, be blocked on an object monitor, or >>>waiting on an object monitor. Only

Re: RFR: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 23:17:18 GMT, Chris Plummer wrote: > The test waits for a ThreadDeathEvent for "main". Once that arrives, it then > waits for the next ThreadStartEvent (for any thread). Once it arrives, the > test tries to create and enable a StepRequest on the "main" thread. Since > "main"

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread David Holmes
On Thu, 8 Jun 2023 03:36:52 GMT, Serguei Spitsyn wrote: >>> A thread carrying a virtual thread can not be in native, blocked, parked, >>> sleeping or waiting on some object. >> >> A virtual thread can call native code, be blocked on an object monitor, or >> waiting on an object monitor. Only p

Integrated: 8309602: update JVMTI history table for jdk 21

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 12:32:14 GMT, Serguei Spitsyn wrote: > This is a minor update of the `jvmti.xml` file. > The JVM TI history table needs to be updated to list: > - Virtual threads finalized to be a permanent feature. > - Agent start-up in the live phase now specified to print a warning. > >

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v4]

2023-06-07 Thread Serguei Spitsyn
On Thu, 8 Jun 2023 04:01:56 GMT, Serguei Spitsyn wrote: >> This is a minor update of the `jvmti.xml` file. >> The JVM TI history table needs to be updated to list: >> - Virtual threads finalized to be a permanent feature. >> - Agent start-up in the live phase now specified to print a warning. >

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v4]

2023-06-07 Thread Serguei Spitsyn
> This is a minor update of the `jvmti.xml` file. > The JVM TI history table needs to be updated to list: > - Virtual threads finalized to be a permanent feature. > - Agent start-up in the live phase now specified to print a warning. > > The JVM TI history table has no normative changes. This up

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
On Thu, 8 Jun 2023 02:07:00 GMT, David Holmes wrote: > > A thread carrying a virtual thread can not be in native, blocked, parked, > > sleeping or waiting on some object. >A virtual thread can call native code, be blocked on an object monitor, or >waiting on an object monitor. Only parking and

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread David Holmes
On Thu, 8 Jun 2023 01:40:06 GMT, Serguei Spitsyn wrote: >> The INTERRUPTED bit we need has to be returned by the >> `java_lang_Thread::get_thread_status`. >> Not completely sure but the bit jt->is_interrupted(false) can be set for the >> mounted virtual thread. >> The JVMTI InterruptThread call

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 23:08:52 GMT, Serguei Spitsyn wrote: >>> A thread carrying a virtual thread can not be in native, blocked, parked, >>> sleeping or waiting on some object. >> >> Actually it can be in native. >> And if I remember correctly synchronized block pins virtual thread, so >> inside

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v6]

2023-06-07 Thread Serguei Spitsyn
> This is REDO the fix of > [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). > The last update of the fix in the review cycle was incorrect and incorrectly > tested, so the issue has not been noticed. It is why the fix was backed out. > The issue is that the SUSPEND bit was missed in t

RFR: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"

2023-06-07 Thread Chris Plummer
The test waits for a ThreadDeathEvent for "main". Once that arrives, it then waits for the next ThreadStartEvent (for any thread). Once it arrives, the test tries to create and enable a StepRequest on the "main" thread. Since "main" is supposedly dead, the expectation is an IllegalThreadStateExc

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 22:48:47 GMT, Alex Menkov wrote: >> Do you need to check jt->is_interrupted(false) and set INTERRUPTED bit? >> It looks like java_lang_Thread::get_thread_status(thread_oop) can only >> return RUNNABLE in the case and we clear it, so the call is not needed: >> >> if (is_th

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Alex Menkov
On Wed, 7 Jun 2023 22:42:49 GMT, Alex Menkov wrote: >> Good concern. >> There are two bits (and the related RUNNABLE bit) that we care in this >> sub-tree of state bits: `SUSPENDED` and `INTERRUPTED`. This update clones >> these two bits. The RUNNABLE bit must be cleared. >> A thread carrying a

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Alex Menkov
On Wed, 7 Jun 2023 21:52:33 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnvBase.cpp line 765: >> >>> 763: if (is_thread_carrying_vthread(jt, thread_oop)) { >>> 764: state &= ~JVMTI_THREAD_STATE_RUNNABLE; >>> 765: state |= JVMTI_THREAD_STATE_WAITING | >>> JVMTI_THREAD_S

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v5]

2023-06-07 Thread Chris Plummer
On Wed, 7 Jun 2023 21:22:41 GMT, Serguei Spitsyn wrote: >> This is REDO the fix of >> [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). >> The last update of the fix in the review cycle was incorrect and incorrectly >> tested, so the issue has not been noticed. It is why the fix was b

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 21:12:24 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix trailing space in jvmtiEnvBase.cpp > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 765: > >> 763: if (is_thre

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 20:10:24 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix trailing space in jvmtiEnvBase.cpp > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 765: > >> 763: if (is_th

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Alex Menkov
On Wed, 7 Jun 2023 20:05:45 GMT, Serguei Spitsyn wrote: >> This is REDO the fix of >> [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). >> The last update of the fix in the review cycle was incorrect and incorrectly >> tested, so the issue has not been noticed. It is why the fix was b

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v5]

2023-06-07 Thread Serguei Spitsyn
> This is REDO the fix of > [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). > The last update of the fix in the review cycle was incorrect and incorrectly > tested, so the issue has not been noticed. It is why the fix was backed out. > The issue is that the SUSPEND bit was missed in t

Withdrawn: JDK-8307314: Implementation: Generational Shenandoah (Experimental)

2023-06-07 Thread Kelvin Nilsen
On Fri, 26 May 2023 20:46:29 GMT, Kelvin Nilsen wrote: > OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimen

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v17]

2023-06-07 Thread Kelvin Nilsen
On Wed, 7 Jun 2023 18:21:43 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Chris Plummer
On Wed, 7 Jun 2023 20:05:45 GMT, Serguei Spitsyn wrote: >> This is REDO the fix of >> [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). >> The last update of the fix in the review cycle was incorrect and incorrectly >> tested, so the issue has not been noticed. It is why the fix was b

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v4]

2023-06-07 Thread Serguei Spitsyn
> This is REDO the fix of > [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). > The last update of the fix in the review cycle was incorrect and incorrectly > tested, so the issue has not been noticed. It is why the fix was backed out. > The issue is that the SUSPEND bit was missed in t

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v3]

2023-06-07 Thread Serguei Spitsyn
> This is REDO the fix of > [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). > The last update of the fix in the review cycle was incorrect and incorrectly > tested, so the issue has not been noticed. It is why the fix was backed out. > The issue is that the SUSPEND bit was missed in t

Re: RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v2]

2023-06-07 Thread Serguei Spitsyn
> This is REDO the fix of > [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). > The last update of the fix in the review cycle was incorrect and incorrectly > tested, so the issue has not been noticed. It is why the fix was backed out. > The issue is that the SUSPEND bit was missed in t

RFR: 8309612: [R[REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Serguei Spitsyn
This is REDO the fix of [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153). The last update of the fix in the review cycle was incorrect and incorrectly tested, so the issue has not been noticed. It is why the fix was backed out. The issue is that the SUSPEND bit was missed in the JVMTI t

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v16]

2023-06-07 Thread Thomas Stuefe
On Wed, 7 Jun 2023 16:51:38 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v12]

2023-06-07 Thread Thomas Stuefe
On Wed, 7 Jun 2023 14:06:31 GMT, Kelvin Nilsen wrote: > Hi Thomas, > > Thank you for your followup comments. I am in total agreement that it is a > shame the challenges we have faced and the progress we have made is not > better documented in the history of JBS tickets. I have been the worst

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v17]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Integrated: 8309420: com/sun/jdi/StepTest.java fails with virtual thread wrapper

2023-06-07 Thread Chris Plummer
On Mon, 5 Jun 2023 04:03:57 GMT, Chris Plummer wrote: > The test has two issues. The first is that it assume that once the VMStart > event has arrived and one "step into" is done, it will be in the main method > of the debuggee. Once there, it determines the debuggee class name by looking > at

Re: RFR: 8309420: com/sun/jdi/StepTest.java fails with virtual thread wrapper

2023-06-07 Thread Chris Plummer
On Mon, 5 Jun 2023 04:03:57 GMT, Chris Plummer wrote: > The test has two issues. The first is that it assume that once the VMStart > event has arrived and one "step into" is done, it will be in the main method > of the debuggee. Once there, it determines the debuggee class name by looking > at

Re: RFR: 8309510: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java no longer needs to override startUp() method

2023-06-07 Thread Chris Plummer
On Tue, 6 Jun 2023 00:36:12 GMT, Chris Plummer wrote: > com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java currently overrides > the TestScaffold.startup() method: > > // override this to correct a bug so arguments can be passed to > // the Target class > protected void startUp(

Integrated: 8309510: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java no longer needs to override startUp() method

2023-06-07 Thread Chris Plummer
On Tue, 6 Jun 2023 00:36:12 GMT, Chris Plummer wrote: > com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java currently overrides > the TestScaffold.startup() method: > > // override this to correct a bug so arguments can be passed to > // the Target class > protected void startUp(

Re: RFR: 8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory

2023-06-07 Thread Chris Plummer
On Tue, 6 Jun 2023 00:02:47 GMT, Chris Plummer wrote: > The test fails with the virtual test thread factory because it tries to find > the "main" thread in the list of threads returned by JDI, but "main" is a > virtual thread and will only be returned by JDI if the debug agent is > launched wi

Integrated: 8309509: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java fails with virtual test thread factory

2023-06-07 Thread Chris Plummer
On Tue, 6 Jun 2023 00:02:47 GMT, Chris Plummer wrote: > The test fails with the virtual test thread factory because it tries to find > the "main" thread in the list of threads returned by JDI, but "main" is a > virtual thread and will only be returned by JDI if the debug agent is > launched wi

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v16]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v15]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v3]

2023-06-07 Thread Iris Clark
On Wed, 7 Jun 2023 13:08:00 GMT, Serguei Spitsyn wrote: >> This is a minor update of the `jvmti.xml` file. >> The JVM TI history table needs to be updated to list: >> - Virtual threads finalized to be a permanent feature. >> - Agent start-up in the live phase now specified to print a warning. >

Re: RFR: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Daniel D . Daugherty
On Wed, 7 Jun 2023 14:33:51 GMT, Daniel D. Daugherty wrote: > This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. macosx-aarch64-debug has now passed with the [BACKOUT]. That config failed in 2 of the 3 Tier1 job sets that had sightings of this failure mode. - PR Comment:

Integrated: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Daniel D . Daugherty
On Wed, 7 Jun 2023 14:33:51 GMT, Daniel D. Daugherty wrote: > This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. This pull request has now been integrated. Changeset: 33bb64f2 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/33bb64f24fdffdb2b1a5f21ff432b

Re: RFR: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Daniel D . Daugherty
On Wed, 7 Jun 2023 14:33:51 GMT, Daniel D. Daugherty wrote: > This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. linux-aarch64-debug has now passed with the [BACKOUT]. That config failed in 2 of the 3 Tier1 job sets that had sightings of this failure mode. windows-x64-debug has now

Re: RFR: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Daniel D . Daugherty
On Wed, 7 Jun 2023 14:33:51 GMT, Daniel D. Daugherty wrote: > This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. The linux-x64-debug config has passed with the [BACKOUT]. That config failed in each of the three Tier1 job sets that had sightings of this failure mode. - PR

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v14]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Re: RFR: JDK-8309462: vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop [v3]

2023-06-07 Thread Christoph Langer
On Wed, 7 Jun 2023 14:04:14 GMT, JoKern65 wrote: >> The sys_thread_3() function contains an empty while loop, which by the >> standard can be optimized away. Please refer to discussion in >> https://github.com/llvm/llvm-project/issues/60622 >> The xlc17 compiler is doing so, and IBM claims that

Re: RFR: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Daniel D . Daugherty
On Wed, 7 Jun 2023 14:43:45 GMT, Alexander Zvegintsev wrote: >> This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. > > Marked as reviewed by azvegint (Reviewer). @azvegint - Thanks for the fast review! I'm still waiting for my urgent Tier1 test results... - PR Comment:

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v13]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Re: RFR: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Alexander Zvegintsev
On Wed, 7 Jun 2023 14:33:51 GMT, Daniel D. Daugherty wrote: > This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. Marked as reviewed by azvegint (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14359#pullrequestreview-1467877421

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v6]

2023-06-07 Thread Daniel D . Daugherty
On Wed, 7 Jun 2023 11:48:19 GMT, Serguei Spitsyn wrote: >> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_S

RFR: 8309614: [BACKOUT] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Daniel D . Daugherty
This reverts commit 177e8327d685444d63235567f2a9bde0ec3d51cf. - Commit messages: - Revert "8307153: JVMTI GetThreadState on carrier should return STATE_WAITING" Changes: https://git.openjdk.org/jdk/pull/14359/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14359&range=00 I

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Kelvin Nilsen
On Wed, 7 Jun 2023 07:34:44 GMT, Y. Srinivas Ramakrishna wrote: >> Kelvin Nilsen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright notices > > src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp line 3: > >> 1:

Re: RFR: JDK-8309462: vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop [v3]

2023-06-07 Thread Martin Doerr
On Wed, 7 Jun 2023 14:04:14 GMT, JoKern65 wrote: >> The sys_thread_3() function contains an empty while loop, which by the >> standard can be optimized away. Please refer to discussion in >> https://github.com/llvm/llvm-project/issues/60622 >> The xlc17 compiler is doing so, and IBM claims that

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Kelvin Nilsen
On Wed, 7 Jun 2023 07:52:35 GMT, Y. Srinivas Ramakrishna wrote: >> Kelvin Nilsen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright notices > > src/hotspot/share/gc/shenandoah/shenandoahDegeneratedGC.hpp line 3: > >> 1: /

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v12]

2023-06-07 Thread Kelvin Nilsen
On Wed, 7 Jun 2023 13:37:44 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8309462: vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop [v3]

2023-06-07 Thread JoKern65
> The sys_thread_3() function contains an empty while loop, which by the > standard can be optimized away. Please refer to discussion in > https://github.com/llvm/llvm-project/issues/60622 > The xlc17 compiler is doing so, and IBM claims that they are following the > standard and will not fix th

Re: RFR: JDK-8309462: vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop [v2]

2023-06-07 Thread JoKern65
> The sys_thread_3() function contains an empty while loop, which by the > standard can be optimized away. Please refer to discussion in > https://github.com/llvm/llvm-project/issues/60622 > The xlc17 compiler is doing so, and IBM claims that they are following the > standard and will not fix th

Re: RFR: JDK-8309462: vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop

2023-06-07 Thread JoKern65
On Tue, 6 Jun 2023 09:51:09 GMT, JoKern65 wrote: > The sys_thread_3() function contains an empty while loop, which by the > standard can be optimized away. Please refer to discussion in > https://github.com/llvm/llvm-project/issues/60622 > The xlc17 compiler is doing so, and IBM claims that the

Integrated: JDK-8309225: Fix xlc17 clang 15 warnings in security and servicability

2023-06-07 Thread JoKern65
On Fri, 2 Jun 2023 10:19:53 GMT, JoKern65 wrote: > This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in security and servicability. > > Compiling on AIX with xlc17 which contains the new clang 15 fr

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Kelvin Nilsen
On Wed, 7 Jun 2023 07:54:17 GMT, Y. Srinivas Ramakrishna wrote: >> Kelvin Nilsen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright notices > > src/hotspot/share/gc/shenandoah/shenandoahFullGC.hpp line 3: > >> 1: /* >> 2:

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v12]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v6]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 13:24:32 GMT, Alan Bateman wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: one function renaming > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 1741: > >> 1739: "sanity ch

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v6]

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 11:48:19 GMT, Serguei Spitsyn wrote: >> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_S

Integrated: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-07 Thread Serguei Spitsyn
On Sat, 3 Jun 2023 10:53:04 GMT, Serguei Spitsyn wrote: > When a virtual thread is mounted, the carrier thread should be reported as > "waiting" until the virtual thread unmounts. Right now, GetThreadState > reports a state based the JavaThread status when it should return > JVMTI_THREAD_STATE

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v2]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 12:56:18 GMT, Alan Bateman wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: simplified the latest history entries > > src/hotspot/share/prims/jvmti.xml line 15474: > >> 15472: Vi

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v2]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 12:55:27 GMT, Alan Bateman wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: simplified the latest history entries > > src/hotspot/share/prims/jvmti.xml line 15459: > >> 15457: >> 15

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v3]

2023-06-07 Thread Serguei Spitsyn
> This is a minor update of the `jvmti.xml` file. > The JVM TI history table needs to be updated to list: > - Virtual threads finalized to be a permanent feature. > - Agent start-up in the live phase now specified to print a warning. > > The JVM TI history table is maintained for convenience onl

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v2]

2023-06-07 Thread Alan Bateman
On Wed, 7 Jun 2023 12:57:34 GMT, Serguei Spitsyn wrote: >> This is a minor update of the `jvmti.xml` file. >> The JVM TI history table needs to be updated to list: >> - Virtual threads finalized to be a permanent feature. >> - Agent start-up in the live phase now specified to print a warning. >

Re: RFR: 8309602: update JVMTI history table for jdk 21 [v2]

2023-06-07 Thread Serguei Spitsyn
> This is a minor update of the `jvmti.xml` file. > The JVM TI history table needs to be updated to list new capability, > functions and events added to support virtual threads as a permanent feature > in JDK 21. Also, it should list a minor update with the `Implementation Note` > that dynamic l

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v11]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

RFR: 8309602: update JVMTI history table for jdk 21

2023-06-07 Thread Serguei Spitsyn
This is a minor update of the `jvmti.xml` file. The JVM TI history table needs to be updated to list new capability, functions and events added to support virtual threads as a permanent feature in JDK 21. Also, it should list a minor update with the `Implementation Note` that dynamic loading of

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v10]

2023-06-07 Thread Kelvin Nilsen
> OpenJDK Colleagues: > > Please review this proposed integration of Generational mode for Shenandoah > GC under https://bugs.openjdk.org/browse/JDK-8307314. > > Generational mode of Shenandoah is enabled by adding > `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a > c

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Kelvin Nilsen
On Wed, 7 Jun 2023 07:22:13 GMT, Y. Srinivas Ramakrishna wrote: >> Kelvin Nilsen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright notices > > src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.cpp line

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v6]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 11:48:19 GMT, Serguei Spitsyn wrote: >> When a virtual thread is mounted, the carrier thread should be reported as >> "waiting" until the virtual thread unmounts. Right now, GetThreadState >> reports a state based the JavaThread status when it should return >> JVMTI_THREAD_S

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v6]

2023-06-07 Thread Serguei Spitsyn
> When a virtual thread is mounted, the carrier thread should be reported as > "waiting" until the virtual thread unmounts. Right now, GetThreadState > reports a state based the JavaThread status when it should return > JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY. > The

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v5]

2023-06-07 Thread Serguei Spitsyn
On Wed, 7 Jun 2023 05:50:46 GMT, Alan Bateman wrote: >>> > is_carrying_carrier_thread? a bit artificial, but it's a carrier thread >>> > and it's carrying a virtual thread >>> >>> I guess, your suggestion is `is_carrying_virtual_thread`. Is it right? If >>> so, I like this suggestion. >> >> U

Re: RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v5]

2023-06-07 Thread Serguei Spitsyn
> When a virtual thread is mounted, the carrier thread should be reported as > "waiting" until the virtual thread unmounts. Right now, GetThreadState > reports a state based the JavaThread status when it should return > JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY. > The

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Integrated: 8295976: GetThreadListStackTraces returns wrong state for blocked VirtualThread

2023-06-07 Thread Serguei Spitsyn
On Tue, 6 Jun 2023 00:50:34 GMT, Serguei Spitsyn wrote: > The `GetThreadListStackTraces` returns `JVMTI_THREAD_STATE_RUNNABLE` for a > VirtualThread blocked on a monitor when called for more than one thread. When > called for a single VirtualThread it correctly returns a state that includes >

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Thomas Stuefe
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

2023-06-07 Thread Y . Srinivas Ramakrishna
On Wed, 7 Jun 2023 00:39:52 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8308286 Fix clang warnings in linux code [v4]

2023-06-07 Thread Alexey Ushakov
On Thu, 1 Jun 2023 15:01:37 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sinc