Re: RFR: 8309391: Remove non-failing tests from test/jdk/ProblemList-Virtual.txt

2023-06-02 Thread Leonid Mesnik
On Fri, 2 Jun 2023 20:08:15 GMT, Chris Plummer wrote: > The following two tests no longer seem to be failing with the virtual thread > test factory: > > com/sun/jdi/RedefineG.java 8285422 generic-all > com/sun/jdi/RedefineTTYLineNumber.java 8285422 generic-all > > They can be removed from the

Re: RFR: 8309334: ProcessTools.main() does not properly set thread names when using the virtual thread wrapper

2023-06-02 Thread Leonid Mesnik
On Fri, 2 Jun 2023 21:30:46 GMT, Chris Plummer wrote: > Normally when a virtual thread wrapper is used to run a test, the main thread > is renamed to "old-m-a-i-n" and the new virtual thread that will act as the > main thread is named "main". Neither is being done by `ProcessTools.main()`. > T

Re: RFR: 8309391: Remove non-failing tests from test/jdk/ProblemList-Virtual.txt

2023-06-02 Thread Daniel D . Daugherty
On Fri, 2 Jun 2023 20:08:15 GMT, Chris Plummer wrote: > The following two tests no longer seem to be failing with the virtual thread > test factory: > > com/sun/jdi/RedefineG.java 8285422 generic-all > com/sun/jdi/RedefineTTYLineNumber.java 8285422 generic-all > > They can be removed from the

Re: RFR: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 21:47:47 GMT, Chris Plummer wrote: > JdbMethodExitTest.java tries to determine the jdb threadID for the "main" > thread, and then later use it in jdb commands that require a threadID. It > does this by first having the debuggee execute the following: > > System.out.p

Re: RFR: 8309334: ProcessTools.main() does not properly set thread names when using the virtual thread wrapper

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 21:30:46 GMT, Chris Plummer wrote: > Normally when a virtual thread wrapper is used to run a test, the main thread > is renamed to "old-m-a-i-n" and the new virtual thread that will act as the > main thread is named "main". Neither is being done by `ProcessTools.main()`. > T

RFR: 8309391: Remove non-failing tests from test/jdk/ProblemList-Virtual.txt

2023-06-02 Thread Chris Plummer
The following two tests no longer seem to be failing with the virtual thread test factory: com/sun/jdi/RedefineG.java 8285422 generic-all com/sun/jdi/RedefineTTYLineNumber.java 8285422 generic-all They can be removed from the problem list. I also updated a couple of entries to refer to existing

Integrated: 8308978: regression with a deadlock involving FollowReferences

2023-06-02 Thread Alex Menkov
On Tue, 30 May 2023 22:58:58 GMT, Alex Menkov wrote: > The change fixes regression from JDK-8299414. > There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier > when virtual threads are in mount/unmount transition: > EscapeBarrier requests deoptimization which requires thread s

RFR: 8309396: com/sun/jdi/JdbMethodExitTest.java fails with virtual threads due to a bug in determining the main thread id

2023-06-02 Thread Chris Plummer
JdbMethodExitTest.java tries to determine the jdb threadID for the "main" thread, and then later use it in jdb commands that require a threadID. It does this by first having the debuggee execute the following: System.out.println("threadid="+Thread.currentThread().getId()); And then late

RFR: 8309397: com/sun/jdi/JdbXXX tests fail due to not being run with -Djdk.trackAllThreads

2023-06-02 Thread Chris Plummer
The com/sun/jdi/JdbXXX tests rely on the jdb "threads" command output to find the main thread. If it is a virtual thread, it will not be included in the "threads" output unless the debuggee is run with -Djdk.trackAllThreads, so we need to make sure to include this option when launching the debug

RFR: 8309397: com/sun/jdi/JdbXXX tests fail due to not being run with -Djdk.trackAllThreads

2023-06-02 Thread Chris Plummer
The com/sun/jdi/JdbXXX tests rely on the jdb "threads" command output to find the main thread. If it is a virtual thread, it will not be included in the "threads" output unless the debuggee is run with -Djdk.trackAllThreads, so we need to make sure to include this option when launching the debug

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 19:23:23 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v6]

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 03:44:48 GMT, Serguei Spitsyn wrote: >> The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to >> allow deployment to choose whether to allow agents to be loaded/started in >> the VM. The VM option does the right thing for tools using the Attach API >>

Re: RFR: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit [v2]

2023-06-02 Thread Chris Plummer
On Fri, 2 Jun 2023 04:29:16 GMT, Chris Plummer wrote: >> Virtual threads are always daemon threads, so tests that previously did not >> explicitly wait for test threads to exit sometimes fail with virtual threads >> due to the test exiting before the test threads have exited. A join() for >> e

Integrated: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit

2023-06-02 Thread Chris Plummer
On Thu, 1 Jun 2023 23:03:47 GMT, Chris Plummer wrote: > Virtual threads are always daemon threads, so tests that previously did not > explicitly wait for test threads to exit sometimes fail with virtual threads > due to the test exiting before the test threads have exited. A join() for > each

Re: RFR: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit [v2]

2023-06-02 Thread Alex Menkov
On Fri, 2 Jun 2023 04:29:16 GMT, Chris Plummer wrote: >> Virtual threads are always daemon threads, so tests that previously did not >> explicitly wait for test threads to exit sometimes fail with virtual threads >> due to the test exiting before the test threads have exited. A join() for >> e

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Martin Doerr
On Fri, 2 Jun 2023 18:24:16 GMT, Y. Srinivas Ramakrishna wrote: >> Kelvin Nilsen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Force PLAB sizes to align on card-table size > > src/hotspot/cpu/riscv/gc/shenandoah/c1/shenandoahBarrierSe

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Martin Doerr
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Y . Srinivas Ramakrishna
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit [v2]

2023-06-02 Thread Leonid Mesnik
On Fri, 2 Jun 2023 04:29:16 GMT, Chris Plummer wrote: >> Virtual threads are always daemon threads, so tests that previously did not >> explicitly wait for test threads to exit sometimes fail with virtual threads >> due to the test exiting before the test threads have exited. A join() for >> e

RFR: JDK-8309225: Fix xlc17 clang 15 warnings in security and servicability

2023-06-02 Thread JoKern65
This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared code https://github.com/openjdk/jdk/pull/14146 It handles the part in security and servicability. Compiling on AIX with xlc17 which contains the new clang 15 frontend shows the following warnings: src/java.security.jgss

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Feilong Jiang
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8308090: Add container tests for on-the-fly resource quota updates [v2]

2023-06-02 Thread Severin Gehwolf
On Tue, 23 May 2023 09:04:11 GMT, Severin Gehwolf wrote: >> Please review these test changes which implement automatic testing of >> container resource updates without JVM restart. Note that this merely tests >> container detection code handling this case. It doesn't do anything special >> for

Integrated: 8308090: Add container tests for on-the-fly resource quota updates

2023-06-02 Thread Severin Gehwolf
On Mon, 22 May 2023 16:40:40 GMT, Severin Gehwolf wrote: > Please review these test changes which implement automatic testing of > container resource updates without JVM restart. Note that this merely tests > container detection code handling this case. It doesn't do anything special > for the

Re: RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v4]

2023-06-02 Thread Stefan Karlsson
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote: >> OpenJDK Colleagues: >> >> Please review this proposed integration of Generational mode for Shenandoah >> GC under https://bugs.openjdk.org/browse/JDK-8307314. >> >> Generational mode of Shenandoah is enabled by adding >> `-XX:+UnlockExp

Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code [v2]

2023-06-02 Thread Serguei Spitsyn
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote: >> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes >> I'd appreciate if this was considered trivial. > > Johan Sjölen has updated the pull request incrementally with two additional > commits since the last revisi