On Thu, 1 Jun 2023 23:03:47 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> Virtual threads are always daemon threads, so tests that previously did not > explicitly wait for test threads to exit sometimes fail with virtual threads > due to the test exiting before the test threads have exited. A join() for > each test thread is needed to fix this issue. > > com/sun/jdi/DeferredStepTest.java is one such tests. I looked at the other > com/sun/jdi failures listed in > [JDK-8285422](https://bugs.openjdk.org/browse/JDK-8285422) and didn't see any > others that might be failing for this same reason. > > I tested locally with `JTREG_TEST_THREAD_FACTORY=Virtual`. I'll also run the > appropriate mach5 tier that tests com/sun/jdi with virtual threads. This pull request has now been integrated. Changeset: 1bb037bd Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/1bb037bdc6cd76a15f85c05d8c1972ac53b9b3cd Stats: 12 lines in 2 files changed: 9 ins; 1 del; 2 mod 8309329: com/sun/jdi/DeferredStepTest.java fails with virtual threads due to not waiting for threads to exit Reviewed-by: sspitsyn, lmesnik, amenkov ------------- PR: https://git.openjdk.org/jdk/pull/14275
