On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Wed, 31 May 2023 00:37:06 GMT, Chris Plummer wrote:
> PopFramesTest.java is a new test. It could use a couple of minor code
> cleanups, and there is one unused local variable that can be removed.
Marked as reviewed by lmesnik (Reviewer).
-
PR Review: https://git.openjdk.org/jdk
On Wed, 31 May 2023 00:27:16 GMT, Chris Plummer wrote:
> The nsk/jdb tests are not passing the test args on to the debuggee. I found a
> way to pass all of them (see the CR for details), but Windows had trouble
> with the parsing. It turns out the only args that the debuggee really cares
> abo
On Wed, 31 May 2023 01:18:12 GMT, Alex Menkov wrote:
>> The change fixes regression from JDK-8299414.
>> There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier
>> when virtual threads are in mount/unmount transition:
>> EscapeBarrier requests deoptimization which requires thre
On Wed, 31 May 2023 00:37:06 GMT, Chris Plummer wrote:
> PopFramesTest.java is a new test. It could use a couple of minor code
> cleanups, and there is one unused local variable that can be removed.
The test cleanup and clarification look good.
Thanks,
Serguei
-
Marked as reviewed
> The change fixes regression from JDK-8299414.
> There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier
> when virtual threads are in mount/unmount transition:
> EscapeBarrier requests deoptimization which requires thread suspension.
> JvmtiVTMSTransitionDisabler ctor waits unt
On Wed, 31 May 2023 00:27:16 GMT, Chris Plummer wrote:
> The nsk/jdb tests are not passing the test args on to the debuggee. I found a
> way to pass all of them (see the CR for details), but Windows had trouble
> with the parsing. It turns out the only args that the debuggee really cares
> abo
On Tue, 30 May 2023 23:44:28 GMT, Chris Plummer wrote:
> The JDWP spec for StackFrame.SetValue currently states:
>
> "If the thread is a virtual thread then this command can be used to
> set "
> "the value of local variables in the top-most frame when the thread
> is "
>
On Tue, 30 May 2023 22:58:58 GMT, Alex Menkov wrote:
> The change fixes regression from JDK-8299414.
> There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier
> when virtual threads are in mount/unmount transition:
> EscapeBarrier requests deoptimization which requires thread s
PopFramesTest.java is a new test. It could use a couple of minor code cleanups,
and there is one unused local variable that can be removed.
-
Commit messages:
- Some minor comment and code cleanup
Changes: https://git.openjdk.org/jdk/pull/14237/files
Webrev: https://webrevs.openjd
The nsk/jdb tests are not passing the test args on to the debuggee. I found a
way to pass all of them (see the CR for details), but Windows had trouble with
the parsing. It turns out the only args that the debuggee really cares about
are -verbose and -waittime, so I settled on just passing these
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote:
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOM
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOME might be thrown mount/umount or in unparker
> thread.
The JDWP spec for StackFrame.SetValue currently states:
"If the thread is a virtual thread then this command can be used to set
"
"the value of local variables in the top-most frame when the thread is "
"suspended at a breakpoint or single step event. The target VM may
su
The change fixes regression from JDK-8299414.
There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier when
virtual threads are in mount/unmount transition:
EscapeBarrier requests deoptimization which requires thread suspension.
JvmtiVTMSTransitionDisabler ctor waits until all in
On Tue, 30 May 2023 18:42:54 GMT, Coleen Phillimore wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> forgotton _
>
> src/hotspot/share/runtime/javaThread.cpp line 115:
>
>> 113: #include
>> 114: #endif
>> 115:
>
> C
On Tue, 30 May 2023 19:32:11 GMT, Chris Plummer wrote:
>> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long
>> as they are suspended and mounted.
>>
>> [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI
>> ForceEarlyReturn support for virtual th
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOME might be thrown mount/umount or in unparker
> thread.
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote:
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOM
On Tue, 30 May 2023 20:35:05 GMT, Leonid Mesnik wrote:
>> Disable test
>> java/util/concurrent/locks/Lock/OOMEInAQS.java
>> Test provokes OOME and might catch it in an unexpected location. It looks
>> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
>> However, generally th
On Tue, 30 May 2023 20:35:05 GMT, Leonid Mesnik wrote:
>> Disable test
>> java/util/concurrent/locks/Lock/OOMEInAQS.java
>> Test provokes OOME and might catch it in an unexpected location. It looks
>> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
>> However, generally th
On Tue, 30 May 2023 20:35:05 GMT, Leonid Mesnik wrote:
>> Disable test
>> java/util/concurrent/locks/Lock/OOMEInAQS.java
>> Test provokes OOME and might catch it in an unexpected location. It looks
>> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
>> However, generally th
> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long
> as they are suspended and mounted.
>
> [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI
> ForceEarlyReturn support for virtual threads. The spec now says it is
> supported if the thread is s
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Hi, thank you all for the suggestions! I've now applied them. I'll look at
integrating tomorrow.
-
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote:
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOM
On Tue, 30 May 2023 19:51:04 GMT, Serguei Spitsyn wrote:
>> Disable test
>> java/util/concurrent/locks/Lock/OOMEInAQS.java
>> Test provokes OOME and might catch it in an unexpected location. It looks
>> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
>> However, generally
On Tue, 30 May 2023 19:58:09 GMT, Daniel D. Daugherty
wrote:
> Reducing noise in the CI is always good. Especially since it takes
Okay. We should not forget to unproblem-list the two test.
-
PR Comment: https://git.openjdk.org/jdk/pull/14193#issuecomment-1569016457
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote:
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOM
On Tue, 30 May 2023 19:32:11 GMT, Chris Plummer wrote:
>> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long
>> as they are suspended and mounted.
>>
>> [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI
>> ForceEarlyReturn support for virtual th
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote:
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOM
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote:
> Disable test
> java/util/concurrent/locks/Lock/OOMEInAQS.java
> Test provokes OOME and might catch it in an unexpected location. It looks
> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066.
> However, generally the OOM
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Johan Sjölen has updated the pull request incrementally with two additional
commits since the last revision:
- Align
- Suggestions
-
Changes:
- all:
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those chang
OpenJDK Colleagues:
Please review this proposed integration of Generational mode for Shenandoah GC
under https://bugs.openjdk.org/browse/JDK-8307314.
Generational mode of Shenandoah is enabled by adding
`-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a
command line that
On Tue, 30 May 2023 14:20:12 GMT, Volker Simonis wrote:
>> Fixed using a high water mark.
>
> A simple fix for guaranteeing monotonicity, would be to add another field
> (e.g. `max_allocated_bytes`) which keeps the last result returned by
> `getTotalThreadAllocatedBytes()` and the latter would
On Sat, 27 May 2023 15:33:37 GMT, Kim Barrett wrote:
>> I am basically worried that undefining malloc, even if it seems harmless
>> now, exposes us to difficult-to-investigate problems down the road, since it
>> depends on how the libc devs will reform those macros in the future. I would
>> pr
On Fri, 26 May 2023 16:35:32 GMT, Paul Hohensee wrote:
>> The tests and all apps might thank us for keeping last known value, and not
>> returning anything lower, ensuring montonicity.
>
> Fixed using a high water mark.
A simple fix for guaranteeing monotonicity, would be to add another field (
On Thu, 4 May 2023 19:54:57 GMT, Paul Hohensee wrote:
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I'
On Mon, 29 May 2023 17:51:17 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface meth
On Mon, 29 May 2023 22:29:26 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
41 matches
Mail list logo