Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code [v2]

2023-05-30 Thread Amit Kumar
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote: >> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes >> I'd appreciate if this was considered trivial. > > Johan Sjölen has updated the pull request incrementally with two additional > commits since the last revisi

Re: RFR: 8309159: Some minor comment and code cleanup in jdk/com/sun/jdi/PopFramesTest.java

2023-05-30 Thread Leonid Mesnik
On Wed, 31 May 2023 00:37:06 GMT, Chris Plummer wrote: > PopFramesTest.java is a new test. It could use a couple of minor code > cleanups, and there is one unused local variable that can be removed. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk

Re: RFR: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee

2023-05-30 Thread Leonid Mesnik
On Wed, 31 May 2023 00:27:16 GMT, Chris Plummer wrote: > The nsk/jdb tests are not passing the test args on to the debuggee. I found a > way to pass all of them (see the CR for details), but Windows had trouble > with the parsing. It turns out the only args that the debuggee really cares > abo

Re: RFR: 8308978: regression with a deadlock involving FollowReferences [v2]

2023-05-30 Thread Serguei Spitsyn
On Wed, 31 May 2023 01:18:12 GMT, Alex Menkov wrote: >> The change fixes regression from JDK-8299414. >> There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier >> when virtual threads are in mount/unmount transition: >> EscapeBarrier requests deoptimization which requires thre

Re: RFR: 8309159: Some minor comment and code cleanup in jdk/com/sun/jdi/PopFramesTest.java

2023-05-30 Thread Serguei Spitsyn
On Wed, 31 May 2023 00:37:06 GMT, Chris Plummer wrote: > PopFramesTest.java is a new test. It could use a couple of minor code > cleanups, and there is one unused local variable that can be removed. The test cleanup and clarification look good. Thanks, Serguei - Marked as reviewed

Re: RFR: 8308978: regression with a deadlock involving FollowReferences [v2]

2023-05-30 Thread Alex Menkov
> The change fixes regression from JDK-8299414. > There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier > when virtual threads are in mount/unmount transition: > EscapeBarrier requests deoptimization which requires thread suspension. > JvmtiVTMSTransitionDisabler ctor waits unt

Re: RFR: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee

2023-05-30 Thread Serguei Spitsyn
On Wed, 31 May 2023 00:27:16 GMT, Chris Plummer wrote: > The nsk/jdb tests are not passing the test args on to the debuggee. I found a > way to pass all of them (see the CR for details), but Windows had trouble > with the parsing. It turns out the only args that the debuggee really cares > abo

Re: RFR: 8309146: extend JDI StackFrame.setValue() and JDWP StackFrame.setValues minimal support for virtual threads

2023-05-30 Thread Serguei Spitsyn
On Tue, 30 May 2023 23:44:28 GMT, Chris Plummer wrote: > The JDWP spec for StackFrame.SetValue currently states: > > "If the thread is a virtual thread then this command can be used to > set " > "the value of local variables in the top-most frame when the thread > is " >

Re: RFR: 8308978: regression with a deadlock involving FollowReferences

2023-05-30 Thread Serguei Spitsyn
On Tue, 30 May 2023 22:58:58 GMT, Alex Menkov wrote: > The change fixes regression from JDK-8299414. > There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier > when virtual threads are in mount/unmount transition: > EscapeBarrier requests deoptimization which requires thread s

RFR: 8309159: Some minor comment and code cleanup in jdk/com/sun/jdi/PopFramesTest.java

2023-05-30 Thread Chris Plummer
PopFramesTest.java is a new test. It could use a couple of minor code cleanups, and there is one unused local variable that can be removed. - Commit messages: - Some minor comment and code cleanup Changes: https://git.openjdk.org/jdk/pull/14237/files Webrev: https://webrevs.openjd

RFR: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee

2023-05-30 Thread Chris Plummer
The nsk/jdb tests are not passing the test args on to the debuggee. I found a way to pass all of them (see the CR for details), but Windows had trouble with the parsing. It turns out the only args that the debuggee really cares about are -verbose and -waittime, so I settled on just passing these

Integrated: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Leonid Mesnik
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory [v3]

2023-05-30 Thread Leonid Mesnik
> Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOME might be thrown mount/umount or in unparker > thread.

RFR: 8309146: extend JDI StackFrame.setValue() and JDWP StackFrame.setValues minimal support for virtual threads

2023-05-30 Thread Chris Plummer
The JDWP spec for StackFrame.SetValue currently states: "If the thread is a virtual thread then this command can be used to set " "the value of local variables in the top-most frame when the thread is " "suspended at a breakpoint or single step event. The target VM may su

RFR: 8308978: regression with a deadlock involving FollowReferences

2023-05-30 Thread Alex Menkov
The change fixes regression from JDK-8299414. There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier when virtual threads are in mount/unmount transition: EscapeBarrier requests deoptimization which requires thread suspension. JvmtiVTMSTransitionDisabler ctor waits until all in

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-30 Thread JoKern65
On Tue, 30 May 2023 18:42:54 GMT, Coleen Phillimore wrote: >> JoKern65 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> forgotton _ > > src/hotspot/share/runtime/javaThread.cpp line 115: > >> 113: #include >> 114: #endif >> 115: > > C

Re: RFR: 8308819: add JDWP and JDI virtual thread support for ThreadReference.ForceEarlyReturn [v2]

2023-05-30 Thread Alan Bateman
On Tue, 30 May 2023 19:32:11 GMT, Chris Plummer wrote: >> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long >> as they are suspended and mounted. >> >> [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI >> ForceEarlyReturn support for virtual th

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory [v2]

2023-05-30 Thread Leonid Mesnik
> Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOME might be thrown mount/umount or in unparker > thread.

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Leonid Mesnik
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory [v2]

2023-05-30 Thread Daniel D . Daugherty
On Tue, 30 May 2023 20:35:05 GMT, Leonid Mesnik wrote: >> Disable test >> java/util/concurrent/locks/Lock/OOMEInAQS.java >> Test provokes OOME and might catch it in an unexpected location. It looks >> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. >> However, generally th

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory [v2]

2023-05-30 Thread Daniel D . Daugherty
On Tue, 30 May 2023 20:35:05 GMT, Leonid Mesnik wrote: >> Disable test >> java/util/concurrent/locks/Lock/OOMEInAQS.java >> Test provokes OOME and might catch it in an unexpected location. It looks >> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. >> However, generally th

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory [v2]

2023-05-30 Thread Daniel D . Daugherty
On Tue, 30 May 2023 20:35:05 GMT, Leonid Mesnik wrote: >> Disable test >> java/util/concurrent/locks/Lock/OOMEInAQS.java >> Test provokes OOME and might catch it in an unexpected location. It looks >> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. >> However, generally th

Re: RFR: 8308819: add JDWP and JDI virtual thread support for ThreadReference.ForceEarlyReturn [v2]

2023-05-30 Thread Chris Plummer
> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long > as they are suspended and mounted. > > [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI > ForceEarlyReturn support for virtual threads. The spec now says it is > supported if the thread is s

Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code

2023-05-30 Thread Johan Sjölen
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote: > A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes > I'd appreciate if this was considered trivial. Hi, thank you all for the suggestions! I've now applied them. I'll look at integrating tomorrow. -

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Serguei Spitsyn
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Daniel D . Daugherty
On Tue, 30 May 2023 19:51:04 GMT, Serguei Spitsyn wrote: >> Disable test >> java/util/concurrent/locks/Lock/OOMEInAQS.java >> Test provokes OOME and might catch it in an unexpected location. It looks >> like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. >> However, generally

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Serguei Spitsyn
On Tue, 30 May 2023 19:58:09 GMT, Daniel D. Daugherty wrote: > Reducing noise in the CI is always good. Especially since it takes Okay. We should not forget to unproblem-list the two test. - PR Comment: https://git.openjdk.org/jdk/pull/14193#issuecomment-1569016457

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Daniel D . Daugherty
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8308819: add JDWP and JDI virtual thread support for ThreadReference.ForceEarlyReturn [v2]

2023-05-30 Thread Serguei Spitsyn
On Tue, 30 May 2023 19:32:11 GMT, Chris Plummer wrote: >> Improve ThreadReference.ForceEarlyReturn to support virtual threads as long >> as they are suspended and mounted. >> >> [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI >> ForceEarlyReturn support for virtual th

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Daniel D . Daugherty
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-30 Thread Serguei Spitsyn
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code [v2]

2023-05-30 Thread Vladimir Kozlov
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote: >> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes >> I'd appreciate if this was considered trivial. > > Johan Sjölen has updated the pull request incrementally with two additional > commits since the last revisi

Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code [v2]

2023-05-30 Thread Johan Sjölen
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes > I'd appreciate if this was considered trivial. Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision: - Align - Suggestions - Changes: - all:

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-30 Thread Coleen Phillimore
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those chang

RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental)

2023-05-30 Thread Kelvin Nilsen
OpenJDK Colleagues: Please review this proposed integration of Generational mode for Shenandoah GC under https://bugs.openjdk.org/browse/JDK-8307314. Generational mode of Shenandoah is enabled by adding `-XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational` to a command line that

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-30 Thread Paul Hohensee
On Tue, 30 May 2023 14:20:12 GMT, Volker Simonis wrote: >> Fixed using a high water mark. > > A simple fix for guaranteeing monotonicity, would be to add another field > (e.g. `max_allocated_bytes`) which keeps the last result returned by > `getTotalThreadAllocatedBytes()` and the latter would

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-30 Thread Kim Barrett
On Sat, 27 May 2023 15:33:37 GMT, Kim Barrett wrote: >> I am basically worried that undefining malloc, even if it seems harmless >> now, exposes us to difficult-to-investigate problems down the road, since it >> depends on how the libc devs will reform those macros in the future. I would >> pr

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-30 Thread Volker Simonis
On Fri, 26 May 2023 16:35:32 GMT, Paul Hohensee wrote: >> The tests and all apps might thank us for keeping last known value, and not >> returning anything lower, ensuring montonicity. > > Fixed using a high water mark. A simple fix for guaranteeing monotonicity, would be to add another field (

Integrated: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM

2023-05-30 Thread Paul Hohensee
On Thu, 4 May 2023 19:54:57 GMT, Paul Hohensee wrote: > Please review this addition to com.sun.management.ThreadMXBean that returns > the total number of bytes allocated on the Java heap since JVM launch by both > terminated and live threads. > > Because this PR adds a new interface method, I'

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v29]

2023-05-30 Thread Paul Hohensee
On Mon, 29 May 2023 17:51:17 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

Re: RFR: 8308286 Fix clang warnings in linux code [v2]

2023-05-30 Thread Alexey Ushakov
On Mon, 29 May 2023 22:29:26 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin