On Mon, 29 May 2023 22:29:26 GMT, Artem Semenov <aseme...@openjdk.org> wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit since the last revision: > > update Changes requested by avu (Committer). src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 655: > 653: // linker loaded it. We use "base diff" in read_lib_segments call > below. > 654: > 655: if (ps_pdread(ph, (psaddr_t) link_map_addr + > LINK_MAP_ADDR_OFFSET, Extra white spaces before 'if' src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 662: > 660: > 661: // read address of the name > 662: if (ps_pdread(ph, (psaddr_t) link_map_addr + > LINK_MAP_NAME_OFFSET, Extra white-spaces before 'if' src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 717: > 715: > 716: // read next link_map address > 717: if (ps_pdread(ph, (psaddr_t) link_map_addr + > LINK_MAP_NEXT_OFFSET, Extra white-spaces before 'if' src/jdk.jpackage/share/native/common/tstrings.cpp line 60: > 58: #endif > 59: // With g++ this compiles only with '-std=gnu++0x' option > 60: ret = vsnprintf(&*fmtout.begin(), fmtout.size(), format, > args); Extra white-spaces before 'ret' ------------- PR Review: https://git.openjdk.org/jdk/pull/14033#pullrequestreview-1450367357 PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1209893589 PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1209894667 PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1209895275 PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1209895801
