On Tue, 30 May 2023 22:58:58 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The change fixes regression from JDK-8299414. > There is a deadlock between JvmtiVTMSTransitionDisabler and EscapeBarrier > when virtual threads are in mount/unmount transition: > EscapeBarrier requests deoptimization which requires thread suspension. > JvmtiVTMSTransitionDisabler ctor waits until all in progress VTMS transitions > complete, but they cannot be completed as thread is suspended. > To avoid the deadlock mount/unmount transitions should be completed before > EscapeBarrier stuff. The fix itself looks good. However, the following tests must be removed from the `test/hotspot/jtreg/ProblemList-Virtual.txt`: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects001/referringObjects001.java 8308978 generic-all vmTestbase/nsk/jdi/ReferenceType/instances/instances001/instances001.java 8308978 generic-all vmTestbase/nsk/jdi/ReferenceType/instances/instances003/instances003.java 8308978 generic-all vmTestbase/nsk/jdi/ReferenceType/instances/instances004/TestDescription.java 8308978 generic-all vmTestbase/nsk/jdi/MonitorWaitedRequest/addThreadFilter/TestDescription.java 8308978 generic-all vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts002/TestDescription.java 8308978 generic-all vmTestbase/nsk/jdi/stress/serial/monitorEvents002/TestDescription.java 8308978 generic-all vmTestbase/nsk/jdi/stress/serial/heapwalking001/TestDescription.java 8308978 generic-all vmTestbase/nsk/jdi/stress/serial/heapwalking002/TestDescription.java 8308978 generic-all vmTestbase/nsk/jdi/stress/serial/mixed001/TestDescription.java 8308978 generic-all vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t001/TestDescription.java 8308978 generic-all vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t002/TestDescription.java 8308978 generic-all Thanks, Serguei ------------- PR Review: https://git.openjdk.org/jdk/pull/14233#pullrequestreview-1452049700
