Re: RFR: 8307480: Improve SA "transported core" documentation for windows

2023-05-06 Thread Serguei Spitsyn
On Fri, 5 May 2023 23:53:47 GMT, Chris Plummer wrote: > The SA document `transported_core.html` contains some tips on getting core > files to work when debugging it on a machine other than the one that produced > it. There are a few improvements that can be made based on information > provided

Re: RFR: 8306027: Clarify JVMTI heap functions spec about virtual thread stack. [v2]

2023-05-06 Thread Serguei Spitsyn
On Fri, 5 May 2023 23:32:33 GMT, Alex Menkov wrote: >> The fix updates JVMTI spec updates description of heap functions to support >> virtual threads. >> Virtual threads are not heap roots by design, so >> FollowReference/IterateOverReachableObjects specs are updated to note only >> platform t

Re: RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v9]

2023-05-06 Thread Serguei Spitsyn
On Fri, 5 May 2023 22:32:59 GMT, Alex Menkov wrote: >> Sorry, I do not see how this improves readability. >> Big functions with many layered conditions do not improve readability. > > I mean the pieces of the code that set and use > _is_top_frame/_last_entry_frame are close so it's easier to see

Re: RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v16]

2023-05-06 Thread Serguei Spitsyn
On Fri, 5 May 2023 23:03:38 GMT, Alex Menkov wrote: >> The fix updates JVMTI FollowReferences implementation to report references >> from virtual threads: >> - unmounted vthreads are detected, their stack references for >> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL; >> - st

Re: RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v16]

2023-05-06 Thread Serguei Spitsyn
On Fri, 5 May 2023 23:03:38 GMT, Alex Menkov wrote: >> The fix updates JVMTI FollowReferences implementation to report references >> from virtual threads: >> - unmounted vthreads are detected, their stack references for >> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL; >> - st

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-06 Thread Quan Anh Mai
On Sat, 6 May 2023 04:08:42 GMT, Quan Anh Mai wrote: >> Stefan Karlsson has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 917 commits: >> >> - ZGC: Generational >> >>Co-authored-by: Stefan Karlsson >>Co-authored-by: Pe