On Fri, 5 May 2023 22:32:59 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Sorry, I do not see how this improves readability. >> Big functions with many layered conditions do not improve readability. > > I mean the pieces of the code that set and use > _is_top_frame/_last_entry_frame are close so it's easier to see the logic I'd say that it will be even better to find out what are manipulations with these instance fields. They are defined in class scope anyway. Also, you can place the definition of function `report_native_frame_refs()` right after `do_frame()` definition, so they occurrences will be still close. I think, it is more important to see the whole logics of the `do_frame()` with less cascading levels. You can give it a try and see the advantage. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1186671240
